The default bug view has changed. See this FAQ.

Enable jemalloc on MacOS 10.5

RESOLVED FIXED in mozilla10

Status

()

Core
Memory Allocator
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

unspecified
mozilla10
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox10-)

Details

(Whiteboard: [MemShrink:P1])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
(This was originally bug 693404, but that one has morphed into a different issue.)

jemalloc is currently disabled on Mac due to a TP5-RSS regression, bug 670492.

I think this regression is bogus.  We can use the work in bug 693404 to determine whether the regression is real or not.

Once we've definitively established whether jemalloc on 10.5 is a memory win, I think we should consider enabling jemalloc on 10.5, even before we get Talos set up to measure memory usage on 10.5 properly, because jmaher says it may take months to change Talos (bug 693404 comment 17).
(Assignee)

Updated

6 years ago
Whiteboard: [MemShrink]
(Assignee)

Updated

6 years ago
Assignee: nobody → justin.lebar+bug
Whiteboard: [MemShrink] → [MemShrink:P1]

Comment 1

6 years ago
I'm not sure this is worth working on, given that Apple has stopped issuing security updates for Mac OS X 10.5.
(Assignee)

Comment 2

6 years ago
Can we get some data about how many users are on 10.5?

I think so long as we won't check something in if it regresses 10.5, we should consider taking this.  It's not a hard thing; in theory, anyway, we just need to flip a switch.
(Assignee)

Comment 3

6 years ago
Created attachment 569983 [details] [diff] [review]
Patch v1
Attachment #569983 - Flags: review?(khuey)
(Assignee)

Comment 4

6 years ago
I just tested on the 10.5 machine we have in the office.

Test case: Open techcrunch, cnn.  Close both tabs.  Open about:memory, click minimize memory usage.

Latest trunk: 120mb.
With jemalloc enabled: 105mb.
(Assignee)

Comment 5

6 years ago
We'll need to write to dev.tree-management before we push this, since it's going to look like a big regression.
Comment on attachment 569983 [details] [diff] [review]
Patch v1

Review of attachment 569983 [details] [diff] [review]:
-----------------------------------------------------------------

Well that was easy.
Attachment #569983 - Flags: review?(khuey) → review+
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4e4af6b7ae4
Whiteboard: [MemShrink:P1] → [MemShrink:P1][inbound]
(Assignee)

Comment 8

6 years ago
Awesome, this was an 8% TP5 win.

https://groups.google.com/forum/#!topic/mozilla.dev.tree-management/sG5bVt-g_-U
I see this:

  Talos Regression :( Tp5 MozAfterPaint (RSS) increase 18.4% on MacOSX 10.5.8 Mozilla-Inbound

Followed by this:

  Talos Improvement! Tp5 MozAfterPaint decrease 7.93% on MacOSX 10.5.8 Mozilla-Inbound
(Assignee)

Comment 10

6 years ago
Right.  The RSS regression is expected and bogus.  The TP5 speed improvement is neither.  :)
https://hg.mozilla.org/mozilla-central/rev/c4e4af6b7ae4
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [MemShrink:P1][inbound] → [MemShrink:P1]
Target Milestone: --- → mozilla10
(Assignee)

Updated

6 years ago
Depends on: 699101
(Assignee)

Comment 12

6 years ago
This is a big change that we should track for FF10.
tracking-firefox10: --- → ?
(Assignee)

Updated

5 years ago
Depends on: 702250
(Assignee)

Comment 13

5 years ago
Unfortunately we're going to have to back this out of FF10, due to what appears to be an OS-level bug.  Bummer.

Discussion has been in bug 702250.

Updated

5 years ago
tracking-firefox10: ? → -
You need to log in before you can comment on or make changes to this bug.