694345 - Implement signature generation for single-process hangs

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Benjamin Smedberg]

In bug 429592 we are adding a new type of crash report: a report where Firefox has not returned to its event loop for 30 seconds so we kill it off on purpose.

This will be accompanied by an annotation Hang=1.

Later we may want some specialized reports out of socorro, but for now we should make the signature useful. If a report has the Hang=1 annotation, then we should take the normal signature from *Thread 0* and prepand "chromehang | ". Note that thread 0 will not be the crashing thread, which is what we normally use for signatures.

This will distinguish the reports from the plugin hang report pairs which have a "hang | " prefix.

Comment 1

[K Lars Lohn [:lars] [:klohn]]

point of clarification: "take the normal signature from *Thread 0*" - is there ever a chance that the processed minidump will identify a different thread as the "crashing thread"?  In other words, if Hang=1 appears in the metadata, the processor generates the signature from Thread-0 regardless of what thread the processed minidump says is responsible.

Comment 2

[Benjamin Smedberg]

The processed minidump will always identify another thread as the crashing thread. And yes, always generate the signature from thread 0.

Comment 3

[K Lars Lohn [:lars] [:klohn]]

I'm taking this on and will try to squeeze it into the next release,

Comment 4

[[github robot]]

Commits pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/87ad8833d44814069c5dce52bcf4fca3b832182a
fixed enhancement request bug 694345 - added "chromehang"

fixed misbehaving unit tests

fixed incorrect comment

made sure that Hang is interpretted as an int.

https://github.com/mozilla/socorro/commit/4c2478eaca6c77d27c102ca1f58a0d7300b6f9b5
Merge pull request #96 from twobraids/2.3.1

bug 694345 - added "chromehang" signature prefix

Comment 5

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d11293a0a60ec602198cfabcaca271e77d428c5f
Merge pull request #95 from twobraids/master

Bug 694345 - Implement signature generation for single-process hangs

Comment 6

[K Lars Lohn [:lars] [:klohn]]

this is now staged to be part of 2.3.1 -- will be included in the next push to production.