694450 - #winstripe-urlbar-back-button-mask is not vertically centered

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Tss]

Attachment: Identity box bleeding through back-button

The "hole" of the mask is not vertically centered over the identity-box, causing the lower left corner of the identity-box to be visible through the back-button. This is easier to see using a dark Persona or a high contrast Windows theme, and quite visible when back-button is disabled.

Comment 1

[Tss]

Attachment: Screenshot with back-button invisible

Comment 2

[Peter Henkel [:Terepin]]

I filled Bug 694287 yesterday for this, plus more. This is duplicate.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Tss]

Attachment: White shadow over back button

The patch seems to fix the centering problem, but it makes a white shadow appear over the back button when when you pass the cursor over it.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Tss from comment #4)
> Created attachment 567302 [details]
> White shadow over back button
> 
> The patch seems to fix the centering problem, but it makes a white shadow
> appear over the back button when when you pass the cursor over it.

That wouldn't be caused by this patch, it's a different mask.

Comment 6

[Stephen Horlander [:shorlander]]

Comment on attachment 567106 [details] [diff] [review]
patch

Review of attachment 567106 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/7498aeb75412

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/7498aeb75412

Comment 9

[Peter Henkel [:Terepin]]

Wasn't this suppose to be fixed?