#winstripe-urlbar-back-button-mask is not vertically centered

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Theme
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Tss, Assigned: dao)

Tracking

({polish})

Trunk
Firefox 10
x86
Windows 7
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

6 years ago
Created attachment 566968 [details]
Identity box bleeding through back-button

The "hole" of the mask is not vertically centered over the identity-box, causing the lower left corner of the identity-box to be visible through the back-button. This is easier to see using a dark Persona or a high contrast Windows theme, and quite visible when back-button is disabled.
(Reporter)

Comment 1

6 years ago
Created attachment 566969 [details]
Screenshot with back-button invisible
(Assignee)

Updated

6 years ago
Blocks: 682534
Severity: normal → trivial
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
I filled Bug 694287 yesterday for this, plus more. This is duplicate.
(Assignee)

Comment 3

6 years ago
Created attachment 567106 [details] [diff] [review]
patch
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #567106 - Flags: review?(dolske)
(Assignee)

Updated

6 years ago
Attachment #567106 - Flags: review?(dolske) → review?(shorlander)
(Reporter)

Comment 4

6 years ago
Created attachment 567302 [details]
White shadow over back button

The patch seems to fix the centering problem, but it makes a white shadow appear over the back button when when you pass the cursor over it.
(Assignee)

Comment 5

6 years ago
(In reply to Tss from comment #4)
> Created attachment 567302 [details]
> White shadow over back button
> 
> The patch seems to fix the centering problem, but it makes a white shadow
> appear over the back button when when you pass the cursor over it.

That wouldn't be caused by this patch, it's a different mask.
Comment on attachment 567106 [details] [diff] [review]
patch

Review of attachment 567106 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #567106 - Flags: review?(shorlander) → review+
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/7498aeb75412
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/7498aeb75412
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Wasn't this suppose to be fixed?
You need to log in before you can comment on or make changes to this bug.