Last Comment Bug 694621 - IonMonkey: Remove TypeSets from MInstructions
: IonMonkey: Remove TypeSets from MInstructions
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: David Anderson [:dvander]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-14 11:22 PDT by David Anderson [:dvander]
Modified: 2011-10-14 16:49 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (5.93 KB, patch)
2011-10-14 11:22 PDT, David Anderson [:dvander]
sstangl: review+
Details | Diff | Splinter Review

Description David Anderson [:dvander] 2011-10-14 11:22:58 PDT
Created attachment 567142 [details] [diff] [review]
patch

Our model is to query oracle-acquired TypeSets as we build MIR, so afterward they don't appear to be used.
Comment 1 Sean Stangl [:sstangl] 2011-10-14 11:26:45 PDT
Comment on attachment 567142 [details] [diff] [review]
patch

Review of attachment 567142 [details] [diff] [review]:
-----------------------------------------------------------------

I'm still not sure how MCall will handle TypeSets. Should we make a DummyOracle that has a TI-equivalent interface?
Comment 2 David Anderson [:dvander] 2011-10-14 16:49:15 PDT
I'm not sure what you mean - the DummyOracle and TypeInferenceOracle have the same interface.

http://hg.mozilla.org/projects/ionmonkey/rev/7658d0234f19

Note You need to log in before you can comment on or make changes to this bug.