Last Comment Bug 694722 - Remove support code for obsolete platforms from js/src/Makefile.in
: Remove support code for obsolete platforms from js/src/Makefile.in
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Matheus Kerschbaum
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-14 18:43 PDT by Matheus Kerschbaum
Modified: 2011-10-21 02:05 PDT (History)
2 users (show)
matjk7: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.04 KB, patch)
2011-10-14 18:44 PDT, Matheus Kerschbaum
ted: review-
Details | Diff | Splinter Review
patch (2.04 KB, patch)
2011-10-18 13:34 PDT, Matheus Kerschbaum
ted: review+
Details | Diff | Splinter Review

Description Matheus Kerschbaum 2011-10-14 18:43:39 PDT

    
Comment 1 Matheus Kerschbaum 2011-10-14 18:44:55 PDT
Created attachment 567239 [details] [diff] [review]
patch
Comment 2 Ted Mielczarek [:ted.mielczarek] 2011-10-18 07:11:04 PDT
Comment on attachment 567239 [details] [diff] [review]
patch

Review of attachment 567239 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ -917,5 @@
> -	$(HOST_CXX) $(HOST_CXXFLAGS) $(JSCPUCFG_DEFINES) $(DEFINES) -o $@ $<
> -endif
> -else
> -jscpucfg$(HOST_BIN_SUFFIX): jscpucfg.cpp Makefile.in
> -	$(HOST_CXX) $(HOST_CXXFLAGS) $(JSCPUCFG_DEFINES) $(DEFINES) $(NSPR_CFLAGS) $(HOST_OUTOPTION)$@ $<

This else block is the other side of the ifeq ($(OS_ARCH),QNX), so you need to leave it in.
Comment 3 Matheus Kerschbaum 2011-10-18 13:34:21 PDT
Created attachment 567859 [details] [diff] [review]
patch
Comment 5 Marco Bonardo [::mak] 2011-10-21 02:05:32 PDT
https://hg.mozilla.org/mozilla-central/rev/0cec1d2a0705

Note You need to log in before you can comment on or make changes to this bug.