Closed
Bug 694722
Opened 14 years ago
Closed 14 years ago
Remove support code for obsolete platforms from js/src/Makefile.in
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: matjk7, Assigned: matjk7)
Details
Attachments
(1 file, 1 obsolete file)
|
2.04 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #567239 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 567239 [details] [diff] [review]
patch
Review of attachment 567239 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/Makefile.in
@@ -917,5 @@
> - $(HOST_CXX) $(HOST_CXXFLAGS) $(JSCPUCFG_DEFINES) $(DEFINES) -o $@ $<
> -endif
> -else
> -jscpucfg$(HOST_BIN_SUFFIX): jscpucfg.cpp Makefile.in
> - $(HOST_CXX) $(HOST_CXXFLAGS) $(JSCPUCFG_DEFINES) $(DEFINES) $(NSPR_CFLAGS) $(HOST_OUTOPTION)$@ $<
This else block is the other side of the ifeq ($(OS_ARCH),QNX), so you need to leave it in.
Attachment #567239 -
Flags: review?(ted.mielczarek) → review-
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #567239 -
Attachment is obsolete: true
Attachment #567859 -
Flags: review?(ted.mielczarek)
|
|
||
Updated•14 years ago
|
Attachment #567859 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 4•14 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla10
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•