Closed Bug 694722 Opened 13 years ago Closed 13 years ago

Remove support code for obsolete platforms from js/src/Makefile.in

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: matjk7, Assigned: matjk7)

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Flags: in-testsuite-
Attached patch patch (obsolete) — Splinter Review
Attachment #567239 - Flags: review?(ted.mielczarek)
Comment on attachment 567239 [details] [diff] [review]
patch

Review of attachment 567239 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ -917,5 @@
> -	$(HOST_CXX) $(HOST_CXXFLAGS) $(JSCPUCFG_DEFINES) $(DEFINES) -o $@ $<
> -endif
> -else
> -jscpucfg$(HOST_BIN_SUFFIX): jscpucfg.cpp Makefile.in
> -	$(HOST_CXX) $(HOST_CXXFLAGS) $(JSCPUCFG_DEFINES) $(DEFINES) $(NSPR_CFLAGS) $(HOST_OUTOPTION)$@ $<

This else block is the other side of the ifeq ($(OS_ARCH),QNX), so you need to leave it in.
Attachment #567239 - Flags: review?(ted.mielczarek) → review-
Attached patch patchSplinter Review
Attachment #567239 - Attachment is obsolete: true
Attachment #567859 - Flags: review?(ted.mielczarek)
Attachment #567859 - Flags: review?(ted.mielczarek) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0cec1d2a0705
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: