The default bug view has changed. See this FAQ.

Remove support code for obsolete platforms from js/src/Makefile.in

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Matheus Kerschbaum, Assigned: Matheus Kerschbaum)

Tracking

Trunk
mozilla10
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 567239 [details] [diff] [review]
patch
Attachment #567239 - Flags: review?(ted.mielczarek)
Comment on attachment 567239 [details] [diff] [review]
patch

Review of attachment 567239 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ -917,5 @@
> -	$(HOST_CXX) $(HOST_CXXFLAGS) $(JSCPUCFG_DEFINES) $(DEFINES) -o $@ $<
> -endif
> -else
> -jscpucfg$(HOST_BIN_SUFFIX): jscpucfg.cpp Makefile.in
> -	$(HOST_CXX) $(HOST_CXXFLAGS) $(JSCPUCFG_DEFINES) $(DEFINES) $(NSPR_CFLAGS) $(HOST_OUTOPTION)$@ $<

This else block is the other side of the ifeq ($(OS_ARCH),QNX), so you need to leave it in.
Attachment #567239 - Flags: review?(ted.mielczarek) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 567859 [details] [diff] [review]
patch
Attachment #567239 - Attachment is obsolete: true
Attachment #567859 - Flags: review?(ted.mielczarek)
Attachment #567859 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/0cec1d2a0705
Keywords: checkin-needed
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/0cec1d2a0705
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.