VC11 cannot compile the IE profile migration code because pstore.h no longer ships with the SDK

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Migration
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
Firefox 10
x86
Windows 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Therefore, we need to define the stuff that we use from that header ourselves.  This is the header from another SDK installation: https://gist.github.com/1291028
Created attachment 567347 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #567347 - Flags: review?(netzen)
Blocks: 687213
OS: Mac OS X → Windows 8
Comment on attachment 567347 [details] [diff] [review]
Patch (v1)

Review of attachment 567347 [details] [diff] [review]:
-----------------------------------------------------------------

- Verified that I get the problem building with VC2011 on Win7 and Windows SDK v7.1 and that the patch fixes it.
  - The 3 patches procduce a successful build and firefox.exe launches.
- Verified that it doesn't cause a problem with VS2010 w/ 7.1
- Did not try other supported setups but I think it will be OK.
Attachment #567347 - Flags: review?(netzen) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/73e262cd7ee8
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/73e262cd7ee8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
A decision was made a while back not to do this anymore, since the headers are copyrighted by microsoft. I think we should just ifdef out the code that makes use of this in cases where we are building with vc 11.
:jim: would that mean that we would no longer support profile migration from IE?

Gerv

Comment 7

6 years ago
(In reply to Gervase Markham [:gerv] from comment #6)
> :jim: would that mean that we would no longer support profile migration from
> IE?
> 
> Gerv

Looks like it's tied into migrating sign-on information (form data cache) for specific web sites. I wonder though if newer version of ie are even using this. I'll file a bug on investigating whether this code is still doing anything useful.

Updated

6 years ago
Blocks: 698433
You need to log in before you can comment on or make changes to this bug.