Closed Bug 694865 Opened 8 years ago Closed 8 years ago

VC11 cannot compile the IE profile migration code because pstore.h no longer ships with the SDK

Categories

(Firefox :: Migration, defect)

x86
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 10

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

Therefore, we need to define the stuff that we use from that header ourselves.  This is the header from another SDK installation: https://gist.github.com/1291028
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #567347 - Flags: review?(netzen)
Blocks: VC11
OS: Mac OS X → Windows 8
Comment on attachment 567347 [details] [diff] [review]
Patch (v1)

Review of attachment 567347 [details] [diff] [review]:
-----------------------------------------------------------------

- Verified that I get the problem building with VC2011 on Win7 and Windows SDK v7.1 and that the patch fixes it.
  - The 3 patches procduce a successful build and firefox.exe launches.
- Verified that it doesn't cause a problem with VS2010 w/ 7.1
- Did not try other supported setups but I think it will be OK.
Attachment #567347 - Flags: review?(netzen) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/73e262cd7ee8
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/73e262cd7ee8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
A decision was made a while back not to do this anymore, since the headers are copyrighted by microsoft. I think we should just ifdef out the code that makes use of this in cases where we are building with vc 11.
:jim: would that mean that we would no longer support profile migration from IE?

Gerv
(In reply to Gervase Markham [:gerv] from comment #6)
> :jim: would that mean that we would no longer support profile migration from
> IE?
> 
> Gerv

Looks like it's tied into migrating sign-on information (form data cache) for specific web sites. I wonder though if newer version of ie are even using this. I'll file a bug on investigating whether this code is still doing anything useful.
Blocks: 698433
You need to log in before you can comment on or make changes to this bug.