Closed Bug 694867 Opened 13 years ago Closed 13 years ago

nsIScriptContext::ExecuteScript's first parameter should be a JSScript

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(6 files)

As requested in bug 694781 comment 1.
Flags: in-testsuite-
Note that I don't have to change the consumers because they pass the mObject member of ScriptObjectHolder, which I changed in part a.
Attachment #567353 - Flags: review?(mounir)
Same comment as for part d.
Attachment #567354 - Flags: review?(mounir)
Note that nsXULDocument::ExecuteScript is its only caller.
Attachment #567355 - Flags: review?(mounir)
Attachment #567349 - Flags: review?(mounir) → review+
Attachment #567351 - Flags: review?(mounir) → review+
Attachment #567352 - Flags: review?(mounir) → review+
Attachment #567353 - Flags: review?(mounir) → review+
Attachment #567354 - Flags: review?(mounir) → review+
Attachment #567355 - Flags: review?(mounir) → review+
Everything seems fine but it would have been easier to read in one file given that most patches are basically adding some static_cast which are removed by other patches.
Blocks: 695753
Comment on attachment 567351 [details] [diff] [review]
Part b: Pass a JSScript to nsXULPrototypeScript::Set

>--- a/dom/base/nsDOMScriptObjectHolder.h
>+++ b/dom/base/nsDOMScriptObjectHolder.h

>+  JSScript* getObject() const {

Looking back at the patch, mind if I make it getScript?
(In reply to Ms2ger from comment #8)
> Looking back at the patch, mind if I make it getScript?

Makes more sense indeed.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.