694867 - nsIScriptContext::ExecuteScript's first parameter should be a JSScript

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

As requested in bug 694781 comment 1.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Pass a JSScript to nsIScriptContext::Serialize and store a JSScript in nsXULPrototypeScript::ScriptObjectHolder::mObject

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Pass a JSScript to nsXULPrototypeScript::Set

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: Return a JSScript from nsXULPrototypeCache::GetScript

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part d: Store a JSScript in nsXULPrototypeCache

Note that I don't have to change the consumers because they pass the mObject member of ScriptObjectHolder, which I changed in part a.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part e: Pass JSScript to nsXULDocument::ExecuteScript

Same comment as for part d.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part f: Pass a JSScript to nsIScriptContext::ExecuteScript

Note that nsXULDocument::ExecuteScript is its only caller.

Comment 7

[Mounir Lamouri (:mounir)]

Everything seems fine but it would have been easier to read in one file given that most patches are basically adding some static_cast which are removed by other patches.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 567351 [details] [diff] [review]
Part b: Pass a JSScript to nsXULPrototypeScript::Set

>--- a/dom/base/nsDOMScriptObjectHolder.h
>+++ b/dom/base/nsDOMScriptObjectHolder.h

>+  JSScript* getObject() const {

Looking back at the patch, mind if I make it getScript?

Comment 9

[Mounir Lamouri (:mounir)]

(In reply to Ms2ger from comment #8)
> Looking back at the patch, mind if I make it getScript?

Makes more sense indeed.

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/9f14aa19f2e9
https://hg.mozilla.org/mozilla-central/rev/70746df95663
https://hg.mozilla.org/mozilla-central/rev/15904b0261b3
https://hg.mozilla.org/mozilla-central/rev/3b30dade99c9
https://hg.mozilla.org/mozilla-central/rev/00b15d7cf608
https://hg.mozilla.org/mozilla-central/rev/0573e102ae3d