Closed Bug 694932 Opened 13 years ago Closed 13 years ago

GCLI should make the same JS security checks as JSTerm

Categories

(DevTools :: General, defect, P1)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 10

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 2 obsolete files)

upload 3
19.93 KB, patch
dcamp
: review+
Details | Diff | Splinter Review 
      No description provided.
Assignee: nobody → jwalker
Blocks: GCLI-SHIP
Priority: -- → P1
Attached patch upload 1 (obsolete) — — Splinter Review 
You've already seen this in https://github.com/mozilla/gcli/pull/40
Attachment #568430 - Flags: review?(dcamp)
Attachment #568430 - Flags: review?(dcamp) → review+
Status: NEW → ASSIGNED
Attached patch upload 2 (obsolete) — — Splinter Review 
This patch now includes tests, and some significant updates.
See also https://github.com/mozilla/gcli/pull/41
Attachment #568430 - Attachment is obsolete: true
Attachment #569953 - Flags: review?(dcamp)
Attached patch upload 3 — — Splinter Review 
See also: https://github.com/mozilla/gcli/pull/41
Push to try: https://tbpl.mozilla.org/?tree=Try&rev=15373ad4a778

Dave - I r?ed you so there was a record here. Not sure if that's needed.
Attachment #569953 - Attachment is obsolete: true
Attachment #569953 - Flags: review?(dcamp)
Attachment #571152 - Flags: review?(dcamp)
Comment on attachment 571152 [details] [diff] [review]
upload 3

Probably for the best.
Attachment #571152 - Flags: review?(dcamp) → review+
Try looks clean. Ready to land.
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/d3275ca75d28
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d3275ca75d28
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: