Note: There are a few cases of duplicates in user autocompletion which are being worked on.

GCLI should make the same JS security checks as JSTerm

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Assignee: nobody → jwalker
Blocks: 689605
Priority: -- → P1
Created attachment 568430 [details] [diff] [review]
upload 1

You've already seen this in https://github.com/mozilla/gcli/pull/40
Attachment #568430 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #568430 - Flags: review?(dcamp) → review+
Status: NEW → ASSIGNED
Created attachment 569953 [details] [diff] [review]
upload 2

This patch now includes tests, and some significant updates.
See also https://github.com/mozilla/gcli/pull/41
Attachment #568430 - Attachment is obsolete: true
Attachment #569953 - Flags: review?(dcamp)
Created attachment 571152 [details] [diff] [review]
upload 3

See also: https://github.com/mozilla/gcli/pull/41
Push to try: https://tbpl.mozilla.org/?tree=Try&rev=15373ad4a778

Dave - I r?ed you so there was a record here. Not sure if that's needed.
Attachment #569953 - Attachment is obsolete: true
Attachment #569953 - Flags: review?(dcamp)
Attachment #571152 - Flags: review?(dcamp)

Comment 4

6 years ago
Comment on attachment 571152 [details] [diff] [review]
upload 3

Probably for the best.
Attachment #571152 - Flags: review?(dcamp) → review+
Try looks clean. Ready to land.
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/d3275ca75d28
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d3275ca75d28
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
You need to log in before you can comment on or make changes to this bug.