Closed
Bug 695025
Opened 13 years ago
Closed 13 years ago
don't use false when we really mean NULL
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
2.55 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
The JS engine has several places where we return false from methods that return pointer types. We should be returning NULL instead. (These locations were caught by GCC 4.7's -Wconversion-null flag.) Patch incoming.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #567478 -
Flags: review?(luke)
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 567478 [details] [diff] [review] s/false/NULL/ in appropriate places Thanks!
Attachment #567478 -
Flags: review?(luke) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb73d6774bb0 Thanks for the patch!
Assignee: general → nfroyd
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → mozilla10
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cb73d6774bb0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•