don't use false when we really mean NULL

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The JS engine has several places where we return false from methods that return pointer types.  We should be returning NULL instead.  (These locations were caught by GCC 4.7's -Wconversion-null flag.)  Patch incoming.
(Assignee)

Comment 1

6 years ago
Created attachment 567478 [details] [diff] [review]
s/false/NULL/ in appropriate places
Attachment #567478 - Flags: review?(luke)

Comment 2

6 years ago
Comment on attachment 567478 [details] [diff] [review]
s/false/NULL/ in appropriate places

Thanks!
Attachment #567478 - Flags: review?(luke) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb73d6774bb0

Thanks for the patch!
Assignee: general → nfroyd
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/cb73d6774bb0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.