The default bug view has changed. See this FAQ.

IonMonkey: Remove all references to jsc::ARMAssembler

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mjrosenb, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 567489 [details] [diff] [review]
remove the last  references to JSC::ARMAssembler from Ion code

Mostly pretty clean.  I'd been avoiding this because some files referred directly to MacroAssembler.h.  This has been changed to a conditional inclusion based on the target not being arm.
This should also speed up compilation, since every file that includes IonRegisters (most of the ion codebase) no longer needs to compile every function in the old assembler and macro assembler.
Attachment #567489 - Flags: review?(dvander)
Summary: IM/ARM Remove all references to jsc::ARMAssembler from Ion code → IonMonkey: Remove all references to jsc::ARMAssembler
Comment on attachment 567489 [details] [diff] [review]
remove the last  references to JSC::ARMAssembler from Ion code

Review of attachment 567489 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, sorry for the late review

::: js/src/ion/IonRegisters.h
@@ +58,1 @@
>  namespace js {

Nit: Newline between #endif and namespace

@@ +67,2 @@
>      typedef JSC::MacroAssembler::RegisterID RegisterID;
> +#endif

If you put "typedef JSC::MacroAssembler::Register RegisterID" in x86 and x64's Registers, we can get rid of the #ifdef here.

::: js/src/ion/arm/Architecture-arm.h
@@ +42,5 @@
>  #ifndef jsion_architecture_arm_h__
>  #define jsion_architecture_arm_h__
> +#include <limits.h>
> +#include "jscntxt.h"
> +//#include "assembler/assembler/ARMAssembler.h"

Nit: delete this line

::: js/src/ion/arm/Assembler-arm.h
@@ +42,5 @@
>  #ifndef jsion_cpu_arm_assembler_h__
>  #define jsion_cpu_arm_assembler_h__
>  
>  #include "ion/shared/Assembler-shared.h"
> +//#include "assembler/assembler/ARMAssembler.h"

Nit: delete this line
Attachment #567489 - Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/2b94770c2bf8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.