The default bug view has changed. See this FAQ.

Move js{scan,parse,emit}.{h,cpp} into js/src/frontend/

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 567523 [details] [diff] [review]
v1
Assignee: general → jorendorff
Attachment #567523 - Flags: review?(luke)
(Assignee)

Updated

6 years ago
Blocks: 695097

Comment 2

6 years ago
Comment on attachment 567523 [details] [diff] [review]
v1

Review of attachment 567523 [details] [diff] [review]:
-----------------------------------------------------------------

The style for header include order and spacing is not universal, but we seem to have converged which cdleary has documented: https://wiki.mozilla.org/JavaScript:SpiderMonkey:C%2B%2B_Coding_Style#Includes.  Based on that, style nits below:

::: js/src/jsemit.cpp
@@ +61,5 @@
>  #include "jsscope.h"
>  #include "jsscript.h"
> +#include "frontend/CodeGenerator.h"
> +#include "frontend/Parser.h"
> +#include "frontend/TokenStream.h"

spaces before/after and go after jsautooplen.h

::: js/src/jsparse.cpp
@@ +77,5 @@
>  #include "jsstr.h"
>  #include "jslibmath.h"
> +#include "frontend/CodeGenerator.h"
> +#include "frontend/Parser.h"
> +#include "frontend/TokenStream.h"

spaces before, and after the jsxml/jsdhash

::: js/src/jsatom.cpp
@@ +60,4 @@
>  #include "jsstr.h"
>  #include "jsversion.h"
>  #include "jsxml.h"
> +#include "frontend/Parser.h"

space before

::: js/src/jsfun.cpp
@@ +68,5 @@
>  #include "jsexn.h"
>  #include "jstracer.h"
> +#include "frontend/CodeGenerator.h"
> +#include "frontend/Parser.h"
> +#include "frontend/TokenStream.h"

space before (preexisting)

::: js/src/jsobj.cpp
@@ +77,5 @@
>  #include "json.h"
>  #include "jswatchpoint.h"
>  #include "jswrapper.h"
> +#include "frontend/CodeGenerator.h"
> +#include "frontend/Parser.h"

space before

::: js/src/json.cpp
@@ +57,5 @@
>  #include "jstypes.h"
>  #include "jsstdint.h"
>  #include "jsutil.h"
>  #include "jsxml.h"
> +#include "frontend/TokenStream.h"

space before

::: js/src/jsscript.cpp
@@ +65,5 @@
>  #include "jstracer.h"
>  #if JS_HAS_XDR
>  #include "jsxdrapi.h"
>  #endif
> +#include "frontend/CodeGenerator.h"

space before

::: js/src/shell/js.cpp
@@ +74,5 @@
>  #include "jstypedarray.h"
>  #include "jstypedarrayinlines.h"
>  #include "jsxml.h"
>  #include "jsperf.h"
> +#include "frontend/CodeGenerator.h"

space before

::: js/src/vm/Debugger.cpp
@@ +41,5 @@
>  
>  #include "vm/Debugger.h"
>  #include "jsapi.h"
>  #include "jscntxt.h"
> +#include "frontend/CodeGenerator.h"

moved to the end with spaces (along with several other #includes)

::: js/src/vm/GlobalObject.cpp
@@ +44,5 @@
>  #include "jsexn.h"
>  #include "jsmath.h"
>  #include "json.h"
> +#include "builtin/RegExp.h"
> +#include "frontend/CodeGenerator.h"

space before
Attachment #567523 - Flags: review?(luke) → review+
(Assignee)

Comment 3

6 years ago
Good catch on the spacing. Fixed and pushed.

http://hg.mozilla.org/integration/mozilla-inbound/rev/28fcc7211b70
https://hg.mozilla.org/mozilla-central/rev/28fcc7211b70
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.