Closed
Bug 695138
Opened 14 years ago
Closed 14 years ago
Fix inout memory leak in XPConnect tests
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: bholley, Assigned: bholley)
Details
Attachments
(1 file)
|
1.97 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
I was unclear as to the memory ownership model for inout parameters with dependent buffers, so I got it wrong in nsXPCTestParams::TestString and friends.
I talked to bsmedberg, and clarified the situation. I've updated the docs here to reflect them:
https://developer.mozilla.org/en/XPIDL
The test still needs fixing though.
|
Assignee | |
Comment 1•14 years ago
|
||
Attached a fix. Flagging khuey for review.
Review: khuey
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 568305 [details] [diff] [review]
Fix inout memory leak in XPConnect tests. v1
Oops, didn't actually flag. Flagging khuey.
Attachment #568305 -
Flags: review?(khuey)
Attachment #568305 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/a2d4d5fd846a
Target Milestone: --- → mozilla10
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•