Fix inout memory leak in XPConnect tests

RESOLVED FIXED in mozilla10

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I was unclear as to the memory ownership model for inout parameters with dependent buffers, so I got it wrong in nsXPCTestParams::TestString and friends.

I talked to bsmedberg, and clarified the situation. I've updated the docs here to reflect them:
https://developer.mozilla.org/en/XPIDL

The test still needs fixing though.
Created attachment 568305 [details] [diff] [review]
Fix inout memory leak in XPConnect tests. v1

Attached a fix. Flagging khuey for review.


Review: khuey
Comment on attachment 568305 [details] [diff] [review]
Fix inout memory leak in XPConnect tests. v1

Oops, didn't actually flag. Flagging khuey.
Attachment #568305 - Flags: review?(khuey)
Attachment #568305 - Flags: review?(khuey) → review+
Pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/a2d4d5fd846a
Target Milestone: --- → mozilla10

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/a2d4d5fd846a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.