Closed Bug 695165 Opened 9 years ago Closed 9 years ago

Forward

Categories

(Firefox for Android :: General, defect, P2)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: elan, Assigned: kats)

References

Details

(Keywords: feature)

Attachments

(3 files, 3 obsolete files)

No description provided.
Priority: P1 → P2
Whiteboard: [QA+]
I can put in the plumbing for this pending UX mockups.
Assignee: nobody → kgupta
Attached patch (1/3) Minor cleanup in Tab.java (obsolete) — Splinter Review
Attachment #569986 - Flags: review?(sriram)
Attachment #569986 - Attachment description: (1/1) Minor cleanup in Tab.java → (1/3) Minor cleanup in Tab.java
Attached patch (2/3) Plumbing for Forward (obsolete) — Splinter Review
I found this led to much simpler code than turning mHistory into a list and keeping an index pointer. That approach has lots of corner cases when the list is empty, or the index is out of bounds.
Attachment #569987 - Flags: review?(sriram)
Making this a separate change so that it can be backed out if UX changes without affecting the plumbing part.
Attachment #569988 - Flags: review?(sriram)
Depends on: 697732
Attachment #569986 - Flags: review?(sriram) → review+
Attachment #569988 - Flags: review?(sriram) → review+
Comment on attachment 569987 [details] [diff] [review]
(2/3) Plumbing for Forward

Is there a reason for using 2 stacks? We need to pop from one and push into another. Why not have a List<HistoryEntry> and use an index variable? That operation is faster I guess.
Attachment #569987 - Flags: review?(sriram) → review+
Comment on attachment 569986 [details] [diff] [review]
(1/3) Minor cleanup in Tab.java

Moved this patch to 697732, since those patches need to go in first.
Attachment #569986 - Attachment is obsolete: true
This patch applies on top of the ones from bug 695165
Attachment #569987 - Attachment is obsolete: true
Attachment #570248 - Flags: review?
Rebased the old patch, but no functional changes.
Attachment #569988 - Attachment is obsolete: true
Attachment #570249 - Flags: review+
Drive-by:

* Could we change "session-*" messages to "Session:*" ?
Comment on attachment 570252 [details] [diff] [review]
(3/2) Rename events for consistency

Thanks
Attachment #570252 - Flags: review?(mark.finkle) → review+
Attachment #570248 - Flags: review? → review+
20111031103218
http://hg.mozilla.org/projects/birch/rev/9f5570d58bca
Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
Whiteboard: [QA+]
tracking-fennec: --- → 11+
Keywords: feature
You need to log in before you can comment on or make changes to this bug.