695168 - ErrorHandler tries to use _log before initialization

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

JavaScript error: resource://services-sync/policies.js, line 620: this._log is undefined

Presumably initLogs hasn't yet been called.

(This was clicking Sync Now immediately on browser start.)

Comment 1

[Gregory Szorc [:gps]]

I just saw this on my local Nightly build as well. Although, my line number was different:

JavaScript strict warning: resource://services-sync/policies.js, line 605: reference to undefined property this._log
JavaScript error: resource://services-sync/policies.js, line 605: this._log is undefined

I don't have a this._log on line 620, so I'm guessing :rnewman has something on his patch queue touching policies.js?

I triggered by clicking Sync Now from the toolbar, possibly just before/after a scheduled Sync.

Comment 2

[Richard Newman [:rnewman]]

(In reply to Gregory Szorc [:gps] from comment #1)

> I don't have a this._log on line 620, so I'm guessing :rnewman has something
> on his patch queue touching policies.js?

I do.

Comment 3

[Richard Newman [:rnewman]]

Mark, did you fix this?

Comment 4

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

I don't recall fixing this, but certainly would have if I saw it. A quick look at the code implies this currently can't happen (the log is setup as part of the ctor) so I think we can just close this and deal with it if we ever see it again.