695177 - Sharing

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Erin Lancaster [:elan]]

Java button.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This should also include sharing elements on a webpage, like links, text and maybe images.

Comment 2

[:Margaret Leibovic]

I'm gonna work on this.

Comment 3

[:Margaret Leibovic]

Attachment: patch

I tried duplicating the tab/he lines inside the id.share case, but I was getting compile errors about them already being defined. Then I tried just declaring tab and he at the top of the method without setting values for them and just setting the values below, but then I was getting crashes that I was having a hard time debugging.

So basically, this works, but feel free to tell me if you know a better way to be doing it :)

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 568062 [details] [diff] [review]
patch

Review of attachment 568062 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/GeckoApp.java
@@ -377,5 @@
>                 return true;
>             case R.id.bookmarks:
>                 Intent intent = new Intent(this, GeckoBookmarks.class);
> -               Tab tab = Tabs.getInstance().getSelectedTab();
> -               Tab.HistoryEntry he = tab.getLastHistoryEntry();

Don't move this out of the switch. It's not used by all of the cases so its ok to duplicate the code

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/projects/birch/rev/5a2f08e6022c

Comment 6

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111021 Firefox/10.0a1 Fennec/10.0a1 (birch)
Samsung Galaxy SII (Android 2.3.4)