Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
9 months ago

People

(Reporter: elan, Assigned: Margaret)

Tracking

({feature})

unspecified
ARM
Android
feature
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

(Whiteboard: [QA+] [birch] [Product Approved])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Java button.
(Reporter)

Updated

6 years ago
Priority: -- → P1
This should also include sharing elements on a webpage, like links, text and maybe images.
Priority: P1 → P2
(Assignee)

Comment 2

6 years ago
I'm gonna work on this.
Assignee: nobody → margaret.leibovic
(Assignee)

Comment 3

6 years ago
Created attachment 568062 [details] [diff] [review]
patch

I tried duplicating the tab/he lines inside the id.share case, but I was getting compile errors about them already being defined. Then I tried just declaring tab and he at the top of the method without setting values for them and just setting the values below, but then I was getting crashes that I was having a hard time debugging.

So basically, this works, but feel free to tell me if you know a better way to be doing it :)
Attachment #568062 - Flags: review?(blassey.bugs)
Comment on attachment 568062 [details] [diff] [review]
patch

Review of attachment 568062 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/GeckoApp.java
@@ -377,5 @@
>                 return true;
>             case R.id.bookmarks:
>                 Intent intent = new Intent(this, GeckoBookmarks.class);
> -               Tab tab = Tabs.getInstance().getSelectedTab();
> -               Tab.HistoryEntry he = tab.getLastHistoryEntry();

Don't move this out of the switch. It's not used by all of the cases so its ok to duplicate the code
Attachment #568062 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/projects/birch/rev/5a2f08e6022c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Whiteboard: [QA+]
(Reporter)

Updated

6 years ago
Priority: P2 → P1
Whiteboard: [QA+] → [QA+] [birch] [Product Approved]
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111021 Firefox/10.0a1 Fennec/10.0a1 (birch)
Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
(Reporter)

Updated

5 years ago
Keywords: feature
You need to log in before you can comment on or make changes to this bug.