695214 - XPIDL compiler should enforce [retval] parameters coming last

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Bobby Holley (:bholley)]

It doesn't currently do this. This is bad, because we assume this to be the case within XPConnect.

Comment 1

[Benjamin Smedberg]

They have to be last? That's new to me!

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://mxr.mozilla.org/mozilla2.0/source/xpcom/typelib/xpidl/xpidl_util.c#661

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: patch

Also http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCWrappedJSClass.cpp#1219

Comment 4

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 605526
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=8344741fc63b
Try run started, revision 8344741fc63b. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=8344741fc63b

Comment 5

[Mozilla RelEng Bot]

Try run for 8344741fc63b is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=8344741fc63b
Results (out of 14 total builds):
    success: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-8344741fc63b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/879bb8e92148

Comment 7

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/879bb8e92148