XPIDL compiler should enforce [retval] parameters coming last

RESOLVED FIXED in mozilla14

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bholley, Assigned: froydnj)

Tracking

Trunk
mozilla14
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It doesn't currently do this. This is bad, because we assume this to be the case within XPConnect.
They have to be last? That's new to me!
http://mxr.mozilla.org/mozilla2.0/source/xpcom/typelib/xpidl/xpidl_util.c#661
Assignee: nobody → khuey
(Assignee)

Comment 3

5 years ago
Created attachment 605526 [details] [diff] [review]
patch

Also http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCWrappedJSClass.cpp#1219
Attachment #605526 - Flags: review?(khuey)
(Assignee)

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p all -u none -t none]

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p all -u none -t none] → [autoland-in-queue]

Comment 4

5 years ago
Autoland Patchset:
	Patches: 605526
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=8344741fc63b
Try run started, revision 8344741fc63b. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=8344741fc63b

Comment 5

5 years ago
Try run for 8344741fc63b is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=8344741fc63b
Results (out of 14 total builds):
    success: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-8344741fc63b

Updated

5 years ago
Whiteboard: [autoland-in-queue]
Attachment #605526 - Flags: review?(khuey) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/879bb8e92148
Assignee: khuey → nfroyd
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/879bb8e92148
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.