Last Comment Bug 695243 - Bug 692759 broke clang builds
: Bug 692759 broke clang builds
Status: RESOLVED FIXED
: regression
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla10
Assigned To: :Ehsan Akhgari (busy, don't ask for review please)
:
Mentors:
Depends on:
Blocks: clang 692759
  Show dependency treegraph
 
Reported: 2011-10-17 18:32 PDT by :Ehsan Akhgari (busy, don't ask for review please)
Modified: 2011-10-18 05:44 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (980 bytes, patch)
2011-10-17 18:38 PDT, :Ehsan Akhgari (busy, don't ask for review please)
bgirard: review+
Details | Diff | Review

Description :Ehsan Akhgari (busy, don't ask for review please) 2011-10-17 18:32:08 PDT
/Users/ehsanakhgari/moz/tmp/dom/plugins/ipc/PluginInstanceChild.cpp:477:32: error: non-constant-expression cannot be narrowed
      from type 'uint32_t' (aka 'unsigned int') to 'uint16_t' (aka 'unsigned short') in initializer list
    NPRect windowRect = {0, 0, mWindow.height, mWindow.width};
                               ^~~~~~~~~~~~~~
/Users/ehsanakhgari/moz/tmp/dom/plugins/ipc/PluginInstanceChild.cpp:477:32: note: override this message by inserting an explicit
      cast
    NPRect windowRect = {0, 0, mWindow.height, mWindow.width};
                               ^~~~~~~~~~~~~~
                               static_cast<ui)t16_t>(
/Users/ehsanakhgari/moz/tmp/dom/plugins/ipc/PluginInstanceChild.cpp:477:48: error: non-constant-expression cannot be narrowed
      from type 'uint32_t' (aka 'unsigned int') to 'uint16_t' (aka 'unsigned short') in initializer list
    NPRect windowRect = {0, 0, mWindow.height, mWindow.width};
                                               ^~~~~~~~~~~~~
/Users/ehsanakhgari/moz/tmp/dom/plugins/ipc/PluginInstanceChild.cpp:477:48: note: override this message by inserting an explicit
      cast
    NPRect windowRect = {0, 0, mWindow.height, mWindow.width};
                                               ^~~~~~~~~~~~~
                                               static_cast<u)nt16_t>(
Comment 1 :Ehsan Akhgari (busy, don't ask for review please) 2011-10-17 18:38:00 PDT
Created attachment 567649 [details] [diff] [review]
Patch (v1)
Comment 2 :Ehsan Akhgari (busy, don't ask for review please) 2011-10-17 18:43:18 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/0485355df13d
Comment 3 Marco Bonardo [::mak] 2011-10-18 05:44:25 PDT
https://hg.mozilla.org/mozilla-central/rev/0485355df13d

Note You need to log in before you can comment on or make changes to this bug.