Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Bug 692759 broke clang builds

RESOLVED FIXED in mozilla10

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

({regression})

Trunk
mozilla10
x86
Mac OS X
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

/Users/ehsanakhgari/moz/tmp/dom/plugins/ipc/PluginInstanceChild.cpp:477:32: error: non-constant-expression cannot be narrowed
      from type 'uint32_t' (aka 'unsigned int') to 'uint16_t' (aka 'unsigned short') in initializer list
    NPRect windowRect = {0, 0, mWindow.height, mWindow.width};
                               ^~~~~~~~~~~~~~
/Users/ehsanakhgari/moz/tmp/dom/plugins/ipc/PluginInstanceChild.cpp:477:32: note: override this message by inserting an explicit
      cast
    NPRect windowRect = {0, 0, mWindow.height, mWindow.width};
                               ^~~~~~~~~~~~~~
                               static_cast<ui)t16_t>(
/Users/ehsanakhgari/moz/tmp/dom/plugins/ipc/PluginInstanceChild.cpp:477:48: error: non-constant-expression cannot be narrowed
      from type 'uint32_t' (aka 'unsigned int') to 'uint16_t' (aka 'unsigned short') in initializer list
    NPRect windowRect = {0, 0, mWindow.height, mWindow.width};
                                               ^~~~~~~~~~~~~
/Users/ehsanakhgari/moz/tmp/dom/plugins/ipc/PluginInstanceChild.cpp:477:48: note: override this message by inserting an explicit
      cast
    NPRect windowRect = {0, 0, mWindow.height, mWindow.width};
                                               ^~~~~~~~~~~~~
                                               static_cast<u)nt16_t>(
Created attachment 567649 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #567649 - Flags: review?(bgirard)

Updated

6 years ago
Attachment #567649 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0485355df13d
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/0485355df13d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.