Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Fix precedence problem found with clang warning

RESOLVED FIXED in mozilla10

Status

()

Product:
Core
Component:
DOM
RESOLVED FIXED
Reported:
6 years ago
Modified:
6 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

Version:
Trunk
Target:
mozilla10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Fix precedence problem found with clang warning
877 bytes, patch
mounir
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
6 years ago 
Created attachment 567743 [details] [diff] [review]
Fix precedence problem found with clang warning

'*' has higher precedence than '?' so bracket the expression
so we get what we want.
Attachment #567743 - Flags: review?(mounir)
Attachment #567743 - Flags: review?(mounir) → review+
Version: unspecified → Trunk

Comment 1

•
6 years ago 
https://hg.mozilla.org/mozilla-central/rev/344e0e0cabe4
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10

Comment 2

•
6 years ago 
Ouch.  Another reason why using moz_malloc_usable_size is better than computing a size!  Bug 698968 FTW!
You need to log in before you can comment on or make changes to this bug.