Last Comment Bug 695324 - Fix precedence problem found with clang warning
: Fix precedence problem found with clang warning
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla10
Assigned To: Jeff Muizelaar [:jrmuizel]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-18 07:31 PDT by Jeff Muizelaar [:jrmuizel]
Modified: 2011-11-08 13:54 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix precedence problem found with clang warning (877 bytes, patch)
2011-10-18 07:31 PDT, Jeff Muizelaar [:jrmuizel]
mounir: review+
Details | Diff | Splinter Review

Description Jeff Muizelaar [:jrmuizel] 2011-10-18 07:31:34 PDT
Created attachment 567743 [details] [diff] [review]
Fix precedence problem found with clang warning

'*' has higher precedence than '?' so bracket the expression
so we get what we want.
Comment 1 Marco Bonardo [::mak] (Away 6-20 Aug) 2011-10-21 08:34:41 PDT
https://hg.mozilla.org/mozilla-central/rev/344e0e0cabe4
Comment 2 Nicholas Nethercote [:njn] 2011-11-08 13:54:34 PST
Ouch.  Another reason why using moz_malloc_usable_size is better than computing a size!  Bug 698968 FTW!

Note You need to log in before you can comment on or make changes to this bug.