695325 - netError.dtd should use &brandShortName;

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[[e-mail]]

When I wrote the patch that ended up in bug 451250 the core version of netError.dtd didn't use branding and obviously neither version of the relevant properties file used branding but I overlooked Firefox's override file does in fact use branding and I erroneously hardcoded Firefox in to the file.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[[e-mail]]

Pushed changeset 779adaa83feb to mozilla-central.

Comment 3

[Jesse Ruderman]

Filed bug 696323 for catching this kind of bug automatically.

Comment 4

[Francesco Lodolo [:flod] (OOO Oct 3–10)]

As usual changing a string substantially without changing its key is not the right way to go (even if in this case the missing variable should be caught by compare-locales).

Comment 5

[Francesco Lodolo [:flod] (OOO Oct 3–10)]

(In reply to flod (Francesco Lodolo) from comment #4)
> (even if in this case the missing variable should be caught by compare-locales).
And I'm probably wrong on this one (catches missing variables but not missing entities?)
https://l10n-stage-sj.mozilla.org/dashboard/compare?run=168392

Comment 6

[Axel Hecht [:Pike]]

I'm torn on the key change here, I'd rather go for not doing that.

As for the compare-locales check, right now, it only warns if the localization uses a variable that's not in en-US, not the other way around. Happy to see an experiment by someone.

Comment 7

[[e-mail]]

(In reply to Axel Hecht from comment #6)
> I'm torn on the key change here, I'd rather go for not doing that.
I should post to .l10n though, if only I could remember which of my various profiles is subscribed to it...

Comment 8

[Francesco Lodolo [:flod] (OOO Oct 3–10)]

(In reply to [e-mail] from comment #7)
> I should post to .l10n though, if only I could remember which of my various
> profiles is subscribed to it...

If you need I can do that on dev.l10n (and we can close this bug again).

Comment 9

[Dão Gottwald [:dao]]

(In reply to flod (Francesco Lodolo) from comment #8)
> (In reply to [e-mail] from comment #7)
> > I should post to .l10n though, if only I could remember which of my various
> > profiles is subscribed to it...
> 
> If you need I can do that on dev.l10n (and we can close this bug again).

Please do so. Thanks!

Comment 10

[[e-mail]]

(In reply to Dão Gottwald from comment #9)
> (In reply to Francesco Lodolo from comment #8)
> > (In reply to comment #7)
> > > I should post to .l10n though, if only I could remember which of my various
> > > profiles is subscribed to it...
> > If you need I can do that on dev.l10n (and we can close this bug again).
> Please do so. Thanks!
No need, I already did.