The default bug view has changed. See this FAQ.

netError.dtd should use &brandShortName;

RESOLVED FIXED in mozilla10

Status

()

Core
Document Navigation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
mozilla10
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
When I wrote the patch that ended up in bug 451250 the core version of netError.dtd didn't use branding and obviously neither version of the relevant properties file used branding but I overlooked Firefox's override file does in fact use branding and I erroneously hardcoded Firefox in to the file.
(Assignee)

Comment 1

6 years ago
Created attachment 567744 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #567744 - Flags: review?(gavin.sharp)
Attachment #567744 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 2

6 years ago
Pushed changeset 779adaa83feb to mozilla-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 3

6 years ago
Filed bug 696323 for catching this kind of bug automatically.
Flags: in-testsuite-
As usual changing a string substantially without changing its key is not the right way to go (even if in this case the missing variable should be caught by compare-locales).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to flod (Francesco Lodolo) from comment #4)
> (even if in this case the missing variable should be caught by compare-locales).
And I'm probably wrong on this one (catches missing variables but not missing entities?)
https://l10n-stage-sj.mozilla.org/dashboard/compare?run=168392

Comment 6

6 years ago
I'm torn on the key change here, I'd rather go for not doing that.

As for the compare-locales check, right now, it only warns if the localization uses a variable that's not in en-US, not the other way around. Happy to see an experiment by someone.
(Assignee)

Comment 7

6 years ago
(In reply to Axel Hecht from comment #6)
> I'm torn on the key change here, I'd rather go for not doing that.
I should post to .l10n though, if only I could remember which of my various profiles is subscribed to it...
(In reply to neil@parkwaycc.co.uk from comment #7)
> I should post to .l10n though, if only I could remember which of my various
> profiles is subscribed to it...

If you need I can do that on dev.l10n (and we can close this bug again).
(In reply to flod (Francesco Lodolo) from comment #8)
> (In reply to neil@parkwaycc.co.uk from comment #7)
> > I should post to .l10n though, if only I could remember which of my various
> > profiles is subscribed to it...
> 
> If you need I can do that on dev.l10n (and we can close this bug again).

Please do so. Thanks!
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
OS: Windows XP → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
(Assignee)

Comment 10

6 years ago
(In reply to Dão Gottwald from comment #9)
> (In reply to Francesco Lodolo from comment #8)
> > (In reply to comment #7)
> > > I should post to .l10n though, if only I could remember which of my various
> > > profiles is subscribed to it...
> > If you need I can do that on dev.l10n (and we can close this bug again).
> Please do so. Thanks!
No need, I already did.
You need to log in before you can comment on or make changes to this bug.