Use an indicator in toolbar to reflect security state

VERIFIED FIXED

Status

()

defect
P1
normal
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: elan, Assigned: ju.vermet)

Tracking

({feature})

unspecified
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

(Whiteboard: [birch] [ux needed][QA+])

Attachments

(3 attachments, 2 obsolete attachments)

Reporter

Description

8 years ago
No description provided.
Assignee: nobody → lucasr.at.mozilla
Reporter

Updated

8 years ago
Whiteboard: [birch] [ux needed]
Blocks: 695204
Assigning to Julien who's already working on it.
Assignee: lucasr.at.mozilla → ju.vermet
Assignee

Comment 2

8 years ago
Posted patch Patch v1 (obsolete) — Splinter Review
If security state is high, favicon background is blue, if anything else, favicon background is white.
Assignee

Comment 3

8 years ago
address_bar_button_middle_blue.9.png > embedding/android/resources/drawable/address_bar_button_middle_blue.9.png
The design has changed. We are not using color to show security level in the toolbar.

Instead, we are showing a lock image. The lock will be hidden if there is no level of security on a site. The lock will appear if the site has some level of security. Tapping the lock will open the security panel (bug 695204).

I'll add a mockup
Summary: COLOR of url bar to reflect security state → Use a 'lock' image in toolbar to reflect security state
Posted patch updated patch (obsolete) — Splinter Review
This is an update of Julien Vermet's patch in bug 695204. It adds support for storing the security mode in the Tab and updates the security mode in the BrowserToolbar when loading and switching tabs.
Attachment #569938 - Attachment is obsolete: true
Attachment #571800 - Flags: review?(sriram)
Summary: Use a 'lock' image in toolbar to reflect security state → Use an indicator in toolbar to reflect security state
Comment on attachment 571800 [details] [diff] [review]
updated patch

Review of attachment 571800 [details] [diff] [review]:
-----------------------------------------------------------------

I see one problem here:
handleSecurityChange() is updating the color without checking if the tabId is for the selectedTab. If a SecurityChange arrives for a background tab, the BrowserToolbar will be updated.

I would suggest using "" instead of "unknown". Also, if they are reserved keywords, it's better to define them as constants and use them.
Attachment #571800 - Flags: review?(sriram) → review-
Fixed the selectedTab issue. Leaving "strings" until we move to the next level of this feature, which is bug 695204
Attachment #571800 - Attachment is obsolete: true
Attachment #571803 - Flags: review?(sriram)
Comment on attachment 571803 [details] [diff] [review]
updated patch 2

Review of attachment 571803 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks fine to me.
Attachment #571803 - Flags: review?(sriram) → review+
https://hg.mozilla.org/projects/birch/rev/149e1178490f

Filing a new bug to change the indicator type.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [birch] [ux needed] → [birch] [ux needed][QA+]
(In reply to Mark Finkle (:mfinkle) from comment #10)
> https://hg.mozilla.org/projects/birch/rev/149e1178490f
> 
> Filing a new bug to change the indicator type.

Which?
These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
20111114041052
http://hg.mozilla.org/projects/birch/rev/859ecdfe0168
Samsung Galaxy SII (Android 2.3.4)

Still waiting for the lock bug mentioned in comment #10
Status: RESOLVED → VERIFIED
Duplicate of this bug: 705339
tracking-fennec: --- → 11+
Reporter

Updated

8 years ago
Keywords: feature
You need to log in before you can comment on or make changes to this bug.