Rename everything in the front end

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

6 years ago
The front end is old. It has a lot of names like JSParseNode and JSStmtInfo that should be js::ParseNode and js::StmtInfo.
(Assignee)

Comment 1

6 years ago
Created attachment 567919 [details] [diff] [review]
Part 1, rename types and put enums into namespace js - v1
Assignee: general → jorendorff
Attachment #567919 - Flags: review?(luke)
(Assignee)

Comment 2

6 years ago
Created attachment 567925 [details] [diff] [review]
Part 2, move emitter global functions into namespace js::frontend - v1

js_PopStatement became js::frontend::PopStatementTC rather than js::frontend::PopStatement, because there is already a function named PopStatement, and that one is actually called rather more than this one.
Attachment #567925 - Flags: review?(luke)
(Assignee)

Comment 3

6 years ago
Created attachment 567926 [details] [diff] [review]
Part 3, move tokenizer global functions into namespace js

It is subjective whether js or js::frontend is better. These functions (at least js_IsIdentifier) actually are used outside of the frontend/ subdirectory.
Attachment #567926 - Flags: review?(luke)
(Assignee)

Comment 4

6 years ago
Created attachment 567929 [details] [diff] [review]
Part 4, rename js::Compiler to js::BytecodeCompiler

Elective surgery. I want to rename it to match the filename. (methodjit has a class js::mjit::Compiler. No collision.)

While I was in here I grepped for places where the old filenames jsscan, jsparse, jsemit were still used, so this patch fixes several of those (and deletes some bafflingly ancient super-dead code).
Attachment #567929 - Flags: review?(luke)

Comment 5

6 years ago
Comment on attachment 567919 [details] [diff] [review]
Part 1, rename types and put enums into namespace js - v1

I like it all.
Attachment #567919 - Flags: review?(luke) → review+

Updated

6 years ago
Attachment #567925 - Flags: review?(luke) → review+

Updated

6 years ago
Attachment #567926 - Flags: review?(luke) → review+

Updated

6 years ago
Attachment #567929 - Flags: review?(luke) → review+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/318083d40e1c
https://hg.mozilla.org/integration/mozilla-inbound/rev/39cbf5aa4c4c
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c151e4cc979
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4bd037eb252
https://hg.mozilla.org/mozilla-central/rev/318083d40e1c
https://hg.mozilla.org/mozilla-central/rev/39cbf5aa4c4c
https://hg.mozilla.org/mozilla-central/rev/1c151e4cc979
https://hg.mozilla.org/mozilla-central/rev/a4bd037eb252
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.