The default bug view has changed. See this FAQ.

Scroll indicators for web content

VERIFIED FIXED

Status

()

Firefox for Android
General
P2
normal
VERIFIED FIXED
6 years ago
8 months ago

People

(Reporter: Martijn Wargers (dead), Assigned: kats)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

(Whiteboard: [QA-])

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
I don't see any scroll indicators, while scrolling with Native Fennec.

Updated

6 years ago
OS: Windows 7 → Android
Hardware: x86 → ARM
Summary: Scroll indicators → Scroll indicators for web content

Updated

6 years ago
Whiteboard: [QA+]

Updated

6 years ago
Priority: -- → P2

Updated

6 years ago
Assignee: nobody → kgupta
Created attachment 570357 [details] [diff] [review]
Add scroll indicators
Attachment #570357 - Flags: review?(mark.finkle)
Comment on attachment 570357 [details] [diff] [review]
Add scroll indicators

Actually, this patch doesn't work in all cases. I need to test/debug further. Feedback welcome though.
Attachment #570357 - Flags: review?(mark.finkle) → review-
Created attachment 570743 [details] [diff] [review]
Add scroll indicators (v2)
Attachment #570357 - Attachment is obsolete: true
Attachment #570743 - Flags: review?(mark.finkle)
Comment on attachment 570743 [details] [diff] [review]
Add scroll indicators (v2)


>+  updateScrollbarsFor: function(aElement) {
>+    // only draw the scrollbars if we're scrolling the root content element
>+    if (aElement != this.selectedBrowser.contentDocument.documentElement &&
>+        aElement != this.selectedBrowser.contentDocument.body)
>+      return;

use a local:

let contentDoc = this.selectedBrowser.contentDocument

it's a tiny bit faster and you can leave the condition on a single line

>diff --git a/mobile/chrome/content/browser.xul b/mobile/chrome/content/browser.xul

>+<?xml-stylesheet href="chrome://browser/skin/browser.css" type="text/css"?>

I'd be happier if we gutted the CSS file to only have in it what we need.

Also, I saw a bug where panning to the top or the bottom would get stuck in a "panning" mode and the bars would not hide. Might not be your bug at all. Could be the reason we see text selection when panning too.


r- for the CSS file cleanup
Attachment #570743 - Flags: review?(mark.finkle) → review-
Created attachment 570780 [details] [diff] [review]
(1/3) Add scroll indicators (v3)

Update with JS refactoring as requested.
Attachment #570743 - Attachment is obsolete: true
Attachment #570780 - Flags: review?(mark.finkle)
Created attachment 570781 [details] [diff] [review]
(2/3) Remove unneeded CSS styles
Attachment #570781 - Flags: review?(mark.finkle)
Created attachment 570782 [details] [diff] [review]
(3/3) Stop runaway scrolling behaviour
Attachment #570782 - Flags: review?(chrislord.net)
Attachment #570780 - Flags: review?(mark.finkle) → review+
Attachment #570781 - Flags: review?(mark.finkle) → review+

Comment 8

6 years ago
Comment on attachment 570782 [details] [diff] [review]
(3/3) Stop runaway scrolling behaviour

Review of attachment 570782 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #570782 - Flags: review?(chrislord.net) → review+
https://hg.mozilla.org/projects/birch/rev/0aeaa4995892
https://hg.mozilla.org/projects/birch/rev/e968742b325d
https://hg.mozilla.org/projects/birch/rev/8f32c0c1285c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Should the scroll-indicators have a slight opacity to them so you can still see web content? 

Verified Fixed

20111101040211
http://hg.mozilla.org/projects/birch/rev/7203d86d5868
-- Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED

Updated

6 years ago
Whiteboard: [QA+] → [QA-]
Created attachment 571108 [details] [diff] [review]
(4/3) Make scroll indicators transparent on gingerbread/honeycomb

Not sure if the colors will change later, but for now i'm just making the gingerbread/honeycomb versions the same as the default.
Attachment #571108 - Flags: review?(mark.finkle)
Attachment #571108 - Flags: review?(mark.finkle) → review+
opacity and XUL normally leads to some small performance issues. We'll need to watch out for that.
https://hg.mozilla.org/projects/birch/rev/885ea82d6820

We can revisit this once pcwalton's stuff lands to see if it slows down performance.
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.