695685 - dump in JS modules/components goes to stderr and doesn't flush

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[(not currently active) Ted Mielczarek]

If you call dump() in a JS module or component, it goes to stderr, and doesn't flush stderr. If you call dump() in a window context or a frame script, it goes to stdout and does flush stdout. This is crazy.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Make JS module/component dump go to stdout and flush

This fixes the issue.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 568044 [details] [diff] [review]
Make JS module/component dump go to stdout and flush

Review of attachment 568044 [details] [diff] [review]:
-----------------------------------------------------------------

Should Debug() go to stderr? Also, please use -p in your diffs for review!

Comment 3

[(not currently active) Ted Mielczarek]

Sorry about the diff, apparently I don't have -p in my options on my mac! Making Debug go to stderr doesn't sound unreasonable, but that's a lot more fiddly work than this patch, since right now Debug just calls Dump. I'm just going to push what I have for now, since this fixes a real problem that ahal hit with his harness.

http://hg.mozilla.org/integration/mozilla-inbound/rev/cb7af497e97a

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cb7af497e97a