dump in JS modules/components goes to stderr and doesn't flush

RESOLVED FIXED in mozilla10

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Trunk
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
If you call dump() in a JS module or component, it goes to stderr, and doesn't flush stderr. If you call dump() in a window context or a frame script, it goes to stdout and does flush stdout. This is crazy.
(Assignee)

Comment 1

6 years ago
Created attachment 568044 [details] [diff] [review]
Make JS module/component dump go to stdout and flush

This fixes the issue.
Attachment #568044 - Flags: review?(mrbkap)
Comment on attachment 568044 [details] [diff] [review]
Make JS module/component dump go to stdout and flush

Review of attachment 568044 [details] [diff] [review]:
-----------------------------------------------------------------

Should Debug() go to stderr? Also, please use -p in your diffs for review!
Attachment #568044 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 3

6 years ago
Sorry about the diff, apparently I don't have -p in my options on my mac! Making Debug go to stderr doesn't sound unreasonable, but that's a lot more fiddly work than this patch, since right now Debug just calls Dump. I'm just going to push what I have for now, since this fixes a real problem that ahal hit with his harness.

http://hg.mozilla.org/integration/mozilla-inbound/rev/cb7af497e97a
Status: NEW → ASSIGNED

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/cb7af497e97a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.