Pixman ARM assembly symbols tweaks

NEW
Assigned to

Status

()

7 years ago
7 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
The pixman ARM assembly symbols all end up in the .text section even with -ffunction-sections, and have a size of 0, which makes them invisible to e.g. valgrind.
(Assignee)

Comment 1

7 years ago
Created attachment 568081 [details] [diff] [review]
Pixman ARM assembly symbols tweaks

It would be better if the .section tweaks depended on -ffunction-sections being there, but there's no way to know :-/

I'll need to check if that has some unwanted side effects when not building with -ffunction-sections.

Comment 2

7 years ago
Is using -ffunction-sections option and putting each function into its own section really necessary? Based on my quick test (admittedly done in linux, not android), looks like just the part of your patch adding .size directives is enough to solve valgrind compatibility problems.

Could you please also send your patch to the pixman mailing list or alternatively file a bug with the patch attached at https://bugs.freedesktop.org/ ?

PS. to play nicer with various debugging tools, also adding unwind tables generation directives to the assembly code might be useful sooner or later.
(Assignee)

Comment 3

7 years ago
(In reply to Siarhei Siamashka from comment #2)
> Is using -ffunction-sections option and putting each function into its own
> section really necessary?

It's useful for function/section reordering.

> Could you please also send your patch to the pixman mailing list or
> alternatively file a bug with the patch attached at
> https://bugs.freedesktop.org/ ?

I will, when i figure whether the function section blows things up without -ffunction-sections
You need to log in before you can comment on or make changes to this bug.