695770 - IonMonkey: Compile JSOP_MOD and JSOP_POS

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Jan de Mooij [:jandem]]

Eddy, are you still working on this? We need JSOP_POS to compile x++ where x is a global variable (or property). Not hugely important but please let me know whether I can steal the JSOP_POS part.

Comment 2

[Eddy Bruel [:ejpbruel]]

I did make a start with this bug, but got caught up in moving to my new apartment, hence the lack of updates.

If it is not a high priority, I would like to continue working on this, since it is a great way for me to become familiar with the IonMonkey codebase. Is this ok?

Comment 3

[Jan de Mooij [:jandem]]

(In reply to Eddy Bruel [:ejpbruel] from comment #2)
> If it is not a high priority, I would like to continue working on this,
> since it is a great way for me to become familiar with the IonMonkey
> codebase. Is this ok?

Sure :)

Comment 4

[Eddy Bruel [:ejpbruel]]

I've split this bug up into two separate bugs (see comment above)

Comment 5

[Paul Wright]

So can this bug now be closed since both dependent bugs are complete?

Comment 6

[Eddy Bruel [:ejpbruel]]

Yes and no. JSOP_POS is fully implemented. JSOP_MOD is implemented, but only for x86 and x64, and only for integer operands. We still need support for floating-point operands and ARM. We could make those separate bugs though, in which case this one could be closed.

Comment 7

[Paul Wright]

Any plans to complete this bug per comment 6?

Comment 8

[Jan de Mooij [:jandem]]

(In reply to Paul Wright from comment #7)
> Any plans to complete this bug per comment 6?

This was done some time ago.