Closed Bug 695770 Opened 10 years ago Closed 9 years ago

IonMonkey: Compile JSOP_MOD and JSOP_POS

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ejpbruel, Assigned: ejpbruel)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ion:t])

No description provided.
Blocks: 684381
Assignee: general → ejpbruel
Eddy, are you still working on this? We need JSOP_POS to compile x++ where x is a global variable (or property). Not hugely important but please let me know whether I can steal the JSOP_POS part.
I did make a start with this bug, but got caught up in moving to my new apartment, hence the lack of updates.

If it is not a high priority, I would like to continue working on this, since it is a great way for me to become familiar with the IonMonkey codebase. Is this ok?
(In reply to Eddy Bruel [:ejpbruel] from comment #2)
> If it is not a high priority, I would like to continue working on this,
> since it is a great way for me to become familiar with the IonMonkey
> codebase. Is this ok?

Sure :)
Depends on: 707926
Depends on: 707927
I've split this bug up into two separate bugs (see comment above)
So can this bug now be closed since both dependent bugs are complete?
Yes and no. JSOP_POS is fully implemented. JSOP_MOD is implemented, but only for x86 and x64, and only for integer operands. We still need support for floating-point operands and ARM. We could make those separate bugs though, in which case this one could be closed.
Depends on: 716694
Any plans to complete this bug per comment 6?
(In reply to Paul Wright from comment #7)
> Any plans to complete this bug per comment 6?

This was done some time ago.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.