Last Comment Bug 695936 - Printing messages with attached messages doesn't show their filename
: Printing messages with attached messages doesn't show their filename
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Printing (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 14.0
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-19 19:09 PDT by Jim Porter (:squib)
Modified: 2012-03-18 20:11 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Show the filename for attached messages when printing (677 bytes, patch)
2011-10-19 19:09 PDT, Jim Porter (:squib)
mozilla: review+
bwinton: feedback+
Details | Diff | Review

Description Jim Porter (:squib) 2011-10-19 19:09:52 PDT
Created attachment 568277 [details] [diff] [review]
Show the filename for attached messages when printing

After looking at bug 664640, I noticed that when printing a message with attached messages, the attached messages don't list the filename. You end up with something like this:

  -- image.jpg -------------------

  [ a happy tree ]

  --------------------------------

  Subject: My email
  ...

Now, I'm not actually sure we want to show the filename of the email when printing, but we do show it in the attachment list at the end. In any case, the fix is really easy.
Comment 1 Jim Porter (:squib) 2011-10-19 19:10:47 PDT
Oh, I forgot to say: we also show the filename of the attached email when viewing it or saving it as an HTML file, just not when printing.
Comment 2 Ludovic Hirlimann [:Usul] 2012-01-18 02:16:06 PST
(In reply to Jim Porter (:squib) from comment #0)
> Created attachment 568277 [details] [diff] [review]
> Show the filename for attached messages when printing

Jim why didn't you set any flags on this patch ?
Comment 3 Jim Porter (:squib) 2012-01-18 22:06:35 PST
Comment on attachment 568277 [details] [diff] [review]
Show the filename for attached messages when printing

> (In reply to Jim Porter (:squib) from comment #0)
> Jim why didn't you set any flags on this patch ?

I forgot about this bug, actually...
Comment 4 Blake Winton (:bwinton) (:☕️) 2012-01-24 13:41:46 PST
Comment on attachment 568277 [details] [diff] [review]
Show the filename for attached messages when printing

Yeah, that makes sense to me.

Mumble mumble needs tests, and also, shouldn't you be spending your time on BigFiles?  ;)

Thanks,
Blake.
Comment 5 Jim Porter (:squib) 2012-01-24 13:44:07 PST
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #4)
> Mumble mumble needs tests, and also, shouldn't you be spending your time on
> BigFiles?  ;)

Well, I did upload this last October...
Comment 6 Jim Porter (:squib) 2012-02-01 00:03:28 PST
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #4)
> Mumble mumble needs tests

For my reference when I come back to this: is it even possible to test printing? (Maybe via print preview?)
Comment 7 Jim Porter (:squib) 2012-02-20 22:33:02 PST
Comment on attachment 568277 [details] [diff] [review]
Show the filename for attached messages when printing

Bienvenu, does this look ok? I'd write tests, as Bwinton advised, but I'm not even sure it's possible to test printing.
Comment 8 David :Bienvenu 2012-02-21 08:54:16 PST
Comment on attachment 568277 [details] [diff] [review]
Show the filename for attached messages when printing

yes, it looks OK. I don't know if it's possible to test printing in any reasonable way, but my guess is that it's way harder than it's worth.
Comment 9 Ludovic Hirlimann [:Usul] 2012-02-23 04:24:06 PST
Could we do something like reftest ?
Comment 10 Jim Porter (:squib) 2012-03-18 20:11:06 PDT
Checked in: http://hg.mozilla.org/comm-central/rev/648108b6f425

Since automated tests are a bit difficult for this, maybe we should do a litmus test instead. It should be a simple test:

1) Find an email, and forward it as an attachment to yourself
2) Open the new email, and select "Print Preview"
3) Ensure that the header above the attached message says "<message subject>.eml"

Note You need to log in before you can comment on or make changes to this bug.