695968 - valgrind: Conditional jump or move depends on uninitialised value(s) in nsLookAndFeel::NativeGetColor

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Josh Aas]

Attachment: fix v1.0

==29775== Conditional jump or move depends on uninitialised value(s)
==29775==    at 0x10867A2AF: nsLookAndFeel::NativeGetColor(mozilla::LookAndFeel::ColorID, unsigned int&) (nsLookAndFeel.mm:110)
==29775==    by 0x1086AB63C: nsXPLookAndFeel::GetColorImpl(mozilla::LookAndFeel::ColorID, unsigned int&) (nsXPLookAndFeel.cpp:632)
==29775==    by 0x1086ABDCA: mozilla::LookAndFeel::GetColor(mozilla::LookAndFeel::ColorID, unsigned int*) (nsXPLookAndFeel.cpp:722)
==29775==    by 0x10754F5E1: mozilla::LookAndFeel::GetColor(mozilla::LookAndFeel::ColorID, unsigned int) (LookAndFeel.h:461)
==29775==    by 0x107653AEB: nsTextPaintStyle::InitSelectionColors() (nsTextFrameThebes.cpp:3448)
==29775==    by 0x107653BD2: nsTextPaintStyle::GetSelectionColors(unsigned int*, unsigned int*) (nsTextFrameThebes.cpp:3260)
==29775==    by 0x107653D43: GetSelectionTextColors(short, nsTextPaintStyle&, nsTextRangeStyle const&, unsigned int*, unsigned int*) (nsTextFrameThebes.cpp:4634)
==29775==    by 0x107657BF1: nsTextFrame::PaintTextWithSelectionColors(gfxContext*, gfxPoint const&, gfxPoint const&, gfxRect const&, PropertyProvider&, unsigned int, unsigned int, nsTextPaintStyle&, SelectionDetails*, short*, nsCharClipDisplayItem::ClipEdges const&) (nsTextFrameThebes.cpp:4896)
==29775==    by 0x1076583BE: nsTextFrame::PaintTextWithSelection(gfxContext*, gfxPoint const&, gfxPoint const&, gfxRect const&, PropertyProvider&, unsigned int, unsigned int, nsTextPaintStyle&, nsCharClipDisplayItem::ClipEdges const&) (nsTextFrameThebes.cpp:5081)
==29775==    by 0x107660BDA: nsTextFrame::PaintText(nsRenderingContext*, nsPoint, nsRect const&, nsCharClipDisplayItem const&) (nsTextFrameThebes.cpp:5309)
==29775==    by 0x107660E9B: nsDisplayText::Paint(nsDisplayListBuilder*, nsRenderingContext*) (nsTextFrameThebes.cpp:4177)
==29775==    by 0x1074BBB2E: mozilla::FrameLayerBuilder::DrawThebesLayer(mozilla::layers::ThebesLayer*, gfxContext*, nsIntRegion const&, nsIntRegion const&, void*) (FrameLayerBuilder.cpp:2109)

Comment 1

[Josh Aas]

pushed to mozilla-inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/f0a6064f5fc1

Comment 2

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/f0a6064f5fc1