Closed
Bug 696014
Opened 13 years ago
Closed 13 years ago
[hu] Remove Bluu search engine from Hungarian builds
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 11
People
(Reporter: timar74, Assigned: Milos)
Details
(Keywords: verified-aurora, verified-beta, Whiteboard: [qa!])
Attachments
(2 files, 1 obsolete file)
3.30 KB,
patch
|
Milos
:
review+
|
Details | Diff | Splinter Review |
680 bytes,
patch
|
nthomas
:
review+
christian
:
approval-mozilla-aurora+
christian
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Remove Bluu search engine from Hungarian Firefox, because their site has been down for several weeks and they do not reposond to e-mails.
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → stas
QA Contact: general → kkemenczy
Comment 1•13 years ago
|
||
Thanks for filing the bug, Andras. I was out of the office for 2 weeks which is why I didn't comment earlier. Milos, would you like to take that bug and help Andras? Andras's patch looks good but it will only affect new installs. To remove the plugin retroactively from the existing installs, we will need to add the xml file name to browser/installer/removed-files.in in mozilla-central (and possibly aurora and beta too). CC'ing Axel, too.
Assignee | ||
Updated•13 years ago
|
Assignee: stas → timar74
Component: General → hu / Hungarian
Product: Firefox → Mozilla Localizations
QA Contact: kkemenczy → timar74
Assignee | ||
Updated•13 years ago
|
Attachment #568346 -
Attachment is patch: true
Assignee | ||
Updated•13 years ago
|
Assignee: timar74 → milos
Summary: remove Bluu search engine → [hu] Remove Bluu search engine from Hungarian builds
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to Staś Małolepszy :stas from comment #1) > Milos, would you like to take that bug and help Andras? Sure! Hey Andras, Now that we're removing a search engine, would you like to use this bug and discuss possible replacements for this search engine, or you're good with removing it only, for now?
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to Milos Dinic [:Milos] from comment #2) Hi Milos, Just remove it for the time being. I cannot think of a good replacement.
Assignee | ||
Comment 4•13 years ago
|
||
Andras, Ok. Can you please implement changes from Stas' comment 1, and attach a new patch?
Assignee | ||
Comment 5•13 years ago
|
||
Andras, ping. Do you still want this change?
Reporter | ||
Comment 6•13 years ago
|
||
Milos, yes, I still want this change. Please apply this patch to central, aurora, and beta. Also, please approve the first patch, I can commit it myself. And please, don't ask for more patches. You know what I want: remove bluu. You know how to do that. Why did I need to checkout the whole repo for a one liner patch? Thanks!
Attachment #575120 -
Flags: review?(milos)
Reporter | ||
Updated•13 years ago
|
Attachment #568346 -
Flags: review?(milos)
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 568346 [details] [diff] [review] patch Review of attachment 568346 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, as per previous comments. Please land with appropriate comment, mentioning this bug number, description and my approval(r=milos)
Attachment #568346 -
Flags: review?(milos) → review+
Assignee | ||
Comment 8•13 years ago
|
||
Comment on attachment 575120 [details] [diff] [review] remove bluu.xml from all versions during update Review of attachment 575120 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for this one, r+. Please land with the same descritpion(possibly in the same commit) as previous patch. Now, as far as landing and patches are concerned, we prefer localizers have the full control over their repositories, so that's why we mainly don't commit. Of course, if you're really busy, or have problems with your computer, or anything else comes in your way that makes it hard for you to land your patches, I can give you a hand.
Attachment #575120 -
Flags: review?(milos) → review+
Assignee | ||
Updated•13 years ago
|
Attachment #575120 -
Flags: review?(l10n)
Reporter | ||
Comment 9•13 years ago
|
||
I pushed the fix to all Hungarian l10n repos. The second patch is for browser/installer/removed-files.in in mozilla-central (and aurora, and beta), and I don't have write access, so can you please do it for me. Thanks,
Assignee | ||
Updated•13 years ago
|
Attachment #575120 -
Flags: review?(l10n) → review?(nrthomas)
Comment 10•13 years ago
|
||
Comment on attachment 575120 [details] [diff] [review] remove bluu.xml from all versions during update I'd put it in between these two searchplugins/baidu.src searchplugins/bok-NO.gif to maintain the alphabetical sort. Do you need someone to land this Milos ?
Attachment #575120 -
Flags: review?(nrthomas) → review+
Comment 11•13 years ago
|
||
Nick, Axel -- since the change to the Hungarian repo will happen on l10n/mozilla-aurora, should the removed-files.in patch land on both central and aurora?
Comment 12•13 years ago
|
||
Yes, and landing help would be appreciated.
Comment 13•13 years ago
|
||
As landed: http://hg.mozilla.org/integration/mozilla-inbound/rev/a4492c6d02b0
Attachment #575120 -
Attachment is obsolete: true
Attachment #576841 -
Flags: review+
Comment 14•13 years ago
|
||
Hmm, there are no flags here to request approval for aurora or beta. How do you normally handle that Axel ?
Comment 15•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a4492c6d02b0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Comment 16•13 years ago
|
||
(In reply to Nick Thomas [:nthomas] from comment #14) > Hmm, there are no flags here to request approval for aurora or beta. How do > you normally handle that Axel ? Let's just move it to Firefox and use the flags there. There's really no "usually".
Component: hu / Hungarian → General
Product: Mozilla Localizations → Firefox
Target Milestone: mozilla11 → Firefox 11
Comment 17•13 years ago
|
||
Comment on attachment 576841 [details] [diff] [review] remove bluu.xml from all versions during update, v2 Requesting approval to land the removed-files.in patch in aurora and beta, to correspond with http://hg.mozilla.org/releases/l10n/mozilla-beta/hu/rev/f96dc0a754fd and http://hg.mozilla.org/releases/l10n/mozilla-aurora/hu/rev/6f67195ee19d
Attachment #576841 -
Flags: approval-mozilla-beta?
Attachment #576841 -
Flags: approval-mozilla-aurora?
Comment 18•13 years ago
|
||
FWIW, I have searched mxr's l10n indexes for aurora and beta and found no instances of bluu.xml, so no other locales are using this search engine.
Attachment #576841 -
Flags: approval-mozilla-beta?
Attachment #576841 -
Flags: approval-mozilla-beta+
Attachment #576841 -
Flags: approval-mozilla-aurora?
Attachment #576841 -
Flags: approval-mozilla-aurora+
Comment 19•13 years ago
|
||
Comment on attachment 576841 [details] [diff] [review] remove bluu.xml from all versions during update, v2 http://hg.mozilla.org/releases/mozilla-aurora/rev/187e2ae243b5 http://hg.mozilla.org/releases/mozilla-beta/rev/b100a8d12b9b
Comment 21•13 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; rv:11.0a1) Gecko/20111206 Firefox/11.0a1 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0a1) Gecko/20111206 Firefox/11.0a1 Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111206 Firefox/11.0a1 Mozilla/5.0 (Windows NT 5.1; rv:11.0a1) Gecko/20111206 Firefox/11.0a1 Mozilla/5.0 (Windows NT 6.1; rv:10.0a2) Gecko/20111206 Firefox/10.0a2 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a2) Gecko/20111206 Firefox/10.0a2 Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0a2) Gecko/20111206 Firefox/10.0a2 Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111206 Firefox/10.0a2 Bluu search engine was removed from Nightly and Aurora HU builds (above), but latest Betas (9 beta 4) still have it: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0 Mozilla/5.0 (X11; Linux i686 on x86_64; rv:9.0) Gecko/20100101 Firefox/9.0 Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20100101 Firefox/9.0
Comment 22•13 years ago
|
||
Nick, can you comment on the claim that 9.0 Beta builds do not reflect this change?
Comment 23•13 years ago
|
||
That's consistent with http://hg.mozilla.org/releases/l10n/mozilla-beta/hu/graph/, b4 doesn't have this. B5 should, though.
Comment 24•13 years ago
|
||
Mihaela, please retest this once we get 9.0b5 builds later this week.
Comment 25•13 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0 Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20100101 Firefox/9.0 Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20100101 Firefox/9.0 Verified on latest beta(9beta5) and the Bluu search engine was removed from HU builds. Markiing as VERIFIED.
Status: RESOLVED → VERIFIED
Keywords: verified-aurora,
verified-beta
You need to log in
before you can comment on or make changes to this bug.
Description
•