Closed Bug 696107 Opened 13 years ago Closed 13 years ago

HTML attribute editor in highlighter conflicts with new keyboard controls

Categories

(DevTools :: General, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 10

People

(Reporter: rcampbell, Assigned: rcampbell)

Details

(Whiteboard: [fixed-in-fx-team] [testday-20111125])

Attachments

(1 file, 1 obsolete file)

STR:

1. Open the Highlighter on a webpage.
2. Select an element to lock the highlighter on it.
3. Open the HTML view with the toolbar.
4. Double click an attribute value in the HTML view and change the value.
5. Hit Enter to save the value.

Expected Results:

Attribute value is changed.

Actual Results:

Attribute value is changed but the Highlighter enters Inspect mode again. This is a side-effect.
Priority: -- → P2
Assignee: nobody → rcampbell
Attached patch keyfix (obsolete) — Splinter Review
first pass at a fix. needs tests.
Status: NEW → ASSIGNED
Attached patch keyfix with testSplinter Review
added a basic test
Attachment #572210 - Attachment is obsolete: true
Attachment #572226 - Flags: review?(dcamp)
Whiteboard: [has-patch]
Attachment #572226 - Flags: review?(dcamp) → review+
Whiteboard: [has-patch] → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/0c3401c00152
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/0c3401c00152
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111123 Firefox/10.0a2
Verified fixed. http://screencast.com/t/flnAkF1BNKy
Status: RESOLVED → VERIFIED
Whiteboard: [fixed-in-fx-team] → [fixed-in-fx-team] [testday-20111125]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: