HTML attribute editor in highlighter conflicts with new keyboard controls

VERIFIED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
P2
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Firefox 10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team] [testday-20111125])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
STR:

1. Open the Highlighter on a webpage.
2. Select an element to lock the highlighter on it.
3. Open the HTML view with the toolbar.
4. Double click an attribute value in the HTML view and change the value.
5. Hit Enter to save the value.

Expected Results:

Attribute value is changed.

Actual Results:

Attribute value is changed but the Highlighter enters Inspect mode again. This is a side-effect.

Updated

6 years ago
Priority: -- → P2
(Assignee)

Updated

6 years ago
Assignee: nobody → rcampbell
(Assignee)

Comment 1

6 years ago
Created attachment 572210 [details] [diff] [review]
keyfix

first pass at a fix. needs tests.
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Created attachment 572226 [details] [diff] [review]
keyfix with test

added a basic test
Attachment #572210 - Attachment is obsolete: true
Attachment #572226 - Flags: review?(dcamp)
(Assignee)

Updated

6 years ago
Whiteboard: [has-patch]

Updated

6 years ago
Attachment #572226 - Flags: review?(dcamp) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [has-patch] → [land-in-fx-team]

Comment 3

6 years ago
https://hg.mozilla.org/integration/fx-team/rev/0c3401c00152
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/0c3401c00152
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10

Comment 5

6 years ago
Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111123 Firefox/10.0a2
Verified fixed. http://screencast.com/t/flnAkF1BNKy
Status: RESOLVED → VERIFIED

Updated

6 years ago
Whiteboard: [fixed-in-fx-team] → [fixed-in-fx-team] [testday-20111125]
You need to log in before you can comment on or make changes to this bug.