69613 - Home page on local hard drive with ":\" won't process anchor tags

Status: VERIFIED FIXED

(Core :: Networking: File, defect)

Description

[Peter Skye]

When run for the first time, Warpzilla converts Netscape 
preferences for its own use.  One converted preference is 
the home page -- for example, if the Netscape 4.61 home 
page is file:///d:\internet\www\skyehome.htm then Warpzilla 
will copy this to its own preferences without change.

However, when Warpzilla renders the above home page it 
substitutes hex for the ":" and "\" in the path, i.e. the 
url appears as 
file:///d%3A%5Cinternet%5Cwww%5Cskyehome.htm.

The home page does load.  However, it then doesn't process 
embedded anchor tags properly.  For example, in this home 
page I use anchor tags such as

  <a href="#D_"> D </a>
  ...
  <a name="D_">

and when I click on the above D anchor, Warpzilla tries to 
go to

  file://///d%3A%5Cinternet%5Cwww%5Cskyehome.htm#D_

It doesn't work.  I get a blank window.

Note that after I click on the anchor, Warpzilla displays 
5, not 3, forward slashes after "file:".

The anchor tags work in Netscape 4.61 and 2.02.

Comment 1

[timeless]

os/2

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Move #endif in netwek

Comment 3

[Doug Turner (:dougt)]

The endif matches with a "#if defined(XP_PC) && !defined(XP_OS2)"

r=dougt

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Make what I did a little clearer

Comment 5

[Darin Fisher]

might this substitution cause problems for some UNIX paths?  for example, "\ "
would be used for matching spaces in a path.  but, do we even support that
syntax?  hmm... an what would this mean on the Mac?  shouldn't this be inside
an #ifdef for windows and os/2 ?

Comment 6

[Mike Kaply [:mkaply]]

Darin, you are correct. I'll attach a new diff.

Comment 7

[Mike Kaply [:mkaply]]

Attachment: That code should have been OS/2 Win only

Comment 8

[Darin Fisher]

r/sr=darin

Comment 9

[Mike Kaply [:mkaply]]

Attachment: An even better diff

Comment 10

[Mike Kaply [:mkaply]]

sr on new patch from darin in email

Fix checked in

Comment 11

[benc]

+verifyme: can someone say this works for them now?
+testcase: adding to test suite for file URLs.

Comment 12

[benc]

+qawanted - I have no OS/2.

Comment 13

[Mike Kaply [:mkaply]]

Verify - this is working