[highlighter] Attach the InspectorUI instance when notifying "highlighter-ready"

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
P3
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: paul, Assigned: paul)

Tracking

Trunk
Firefox 11
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox10+ fixed)

Details

(Whiteboard: [fixed-in-fx-team][qa-])

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
When developing an addon, we have to deal with several possible instances of the Inspector (one per window). It would make our life easier if we could just listen to "highlighter-ready" and get the instance from there.
(Assignee)

Comment 1

6 years ago
Created attachment 568436 [details] [diff] [review]
patch v1
(Assignee)

Updated

6 years ago
Attachment #568436 - Flags: review?(rcampbell)
Comment on attachment 568436 [details] [diff] [review]
patch v1

ok
Attachment #568436 - Flags: review?(rcampbell) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [land-in-fx-team]
Comment on attachment 568436 [details] [diff] [review]
patch v1

paul, we should create a test for this before landing. It's ok to tweak one of the initialization tests to check for the object on the observer.

should've asked for this sooner, sorry!

Updated

6 years ago
Priority: -- → P3
Whiteboard: [land-in-fx-team] → [waiting-for-unittest]
(Assignee)

Comment 4

6 years ago
Created attachment 575877 [details] [diff] [review]
patch v1.1
(Assignee)

Updated

6 years ago
Attachment #575877 - Attachment description: with test → patch v1.1
(Assignee)

Updated

6 years ago
Whiteboard: [waiting-for-unittest] → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/ec7522554d45
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Assignee: nobody → paul
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/ec7522554d45
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Comment on attachment 575877 [details] [diff] [review]
patch v1.1

I believe we should land this simple patch in aurora. It's for a new feature and will greatly-improve the add-on potential for the Highlighter. It is low-risk.
Attachment #575877 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Attachment #575877 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

6 years ago
tracking-firefox10: --- → ?
https://hg.mozilla.org/releases/mozilla-aurora/rev/099f38cc6d16
status-firefox10: --- → fixed
Is there something QA can do to verify this fix?
Whiteboard: [fixed-in-fx-team] → [fixed-in-fx-team][qa?]
(Assignee)

Comment 10

6 years ago
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #9)
> Is there something QA can do to verify this fix?

No, not really.
Whiteboard: [fixed-in-fx-team][qa?] → [fixed-in-fx-team][qa-]

Updated

6 years ago
tracking-firefox10: ? → +
You need to log in before you can comment on or make changes to this bug.