Closed
Bug 696139
Opened 14 years ago
Closed 13 years ago
[highlighter] Attach the InspectorUI instance when notifying "highlighter-ready"
Categories
(DevTools :: General, defect, P3)
Tracking
(firefox10+ fixed)
RESOLVED
FIXED
Firefox 11
People
(Reporter: paul, Assigned: paul)
References
Details
(Whiteboard: [fixed-in-fx-team][qa-])
Attachments
(2 files)
1.00 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
2.08 KB,
patch
|
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
When developing an addon, we have to deal with several possible instances of the Inspector (one per window). It would make our life easier if we could just listen to "highlighter-ready" and get the instance from there.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Attachment #568436 -
Flags: review?(rcampbell)
Comment 2•14 years ago
|
||
Comment on attachment 568436 [details] [diff] [review]
patch v1
ok
Attachment #568436 -
Flags: review?(rcampbell) → review+
Assignee | ||
Updated•13 years ago
|
Whiteboard: [land-in-fx-team]
Comment 3•13 years ago
|
||
Comment on attachment 568436 [details] [diff] [review]
patch v1
paul, we should create a test for this before landing. It's ok to tweak one of the initialization tests to check for the object on the observer.
should've asked for this sooner, sorry!
Updated•13 years ago
|
Priority: -- → P3
Updated•13 years ago
|
Whiteboard: [land-in-fx-team] → [waiting-for-unittest]
Assignee | ||
Comment 4•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #575877 -
Attachment description: with test → patch v1.1
Assignee | ||
Updated•13 years ago
|
Whiteboard: [waiting-for-unittest] → [land-in-fx-team]
Comment 5•13 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Updated•13 years ago
|
Assignee: nobody → paul
Status: NEW → ASSIGNED
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Comment 7•13 years ago
|
||
Comment on attachment 575877 [details] [diff] [review]
patch v1.1
I believe we should land this simple patch in aurora. It's for a new feature and will greatly-improve the add-on potential for the Highlighter. It is low-risk.
Attachment #575877 -
Flags: approval-mozilla-aurora?
Updated•13 years ago
|
Attachment #575877 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•13 years ago
|
tracking-firefox10:
--- → ?
Comment 8•13 years ago
|
||
status-firefox10:
--- → fixed
Is there something QA can do to verify this fix?
Whiteboard: [fixed-in-fx-team] → [fixed-in-fx-team][qa?]
Assignee | ||
Comment 10•13 years ago
|
||
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #9)
> Is there something QA can do to verify this fix?
No, not really.
Updated•13 years ago
|
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•