696139 - [highlighter] Attach the InspectorUI instance when notifying "highlighter-ready"

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Paul Rouget [:paul]]

When developing an addon, we have to deal with several possible instances of the Inspector (one per window). It would make our life easier if we could just listen to "highlighter-ready" and get the instance from there.

Comment 1

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 568436 [details] [diff] [review]
patch v1

ok

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 568436 [details] [diff] [review]
patch v1

paul, we should create a test for this before landing. It's ok to tweak one of the initialization tests to check for the object on the observer.

should've asked for this sooner, sorry!

Comment 4

[Paul Rouget [:paul]]

Attachment: patch v1.1

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/ec7522554d45

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/ec7522554d45

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 575877 [details] [diff] [review]
patch v1.1

I believe we should land this simple patch in aurora. It's for a new feature and will greatly-improve the add-on potential for the Highlighter. It is low-risk.

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/099f38cc6d16

Comment 9

[u279076]

Is there something QA can do to verify this fix?

Comment 10

[Paul Rouget [:paul]]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #9)
> Is there something QA can do to verify this fix?

No, not really.