Closed Bug 696139 Opened 10 years ago Closed 9 years ago
[highlighter] Attach the Inspector
UI instance when notifying "highlighter-ready"
When developing an addon, we have to deal with several possible instances of the Inspector (one per window). It would make our life easier if we could just listen to "highlighter-ready" and get the instance from there.
Comment on attachment 568436 [details] [diff] [review] patch v1 ok
Attachment #568436 - Flags: review?(rcampbell) → review+
Comment on attachment 568436 [details] [diff] [review] patch v1 paul, we should create a test for this before landing. It's ok to tweak one of the initialization tests to check for the object on the observer. should've asked for this sooner, sorry!
Whiteboard: [land-in-fx-team] → [waiting-for-unittest]
Attachment #575877 - Attachment description: with test → patch v1.1
Whiteboard: [waiting-for-unittest] → [land-in-fx-team]
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Comment on attachment 575877 [details] [diff] [review] patch v1.1 I believe we should land this simple patch in aurora. It's for a new feature and will greatly-improve the add-on potential for the Highlighter. It is low-risk.
Attachment #575877 - Flags: approval-mozilla-aurora?
Attachment #575877 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Is there something QA can do to verify this fix?
Whiteboard: [fixed-in-fx-team] → [fixed-in-fx-team][qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #9) > Is there something QA can do to verify this fix? No, not really.
You need to log in before you can comment on or make changes to this bug.