Closed Bug 696139 Opened 12 years ago Closed 12 years ago

[highlighter] Attach the InspectorUI instance when notifying "highlighter-ready"

Categories

(DevTools :: General, defect, P3)

Product:
DevTools
Component:
General
Platform:
x86
macOS
Type:
defect

Tracking

(firefox10+ fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 11
Tracking Flags:
Tracking Status
firefox10 + fixed

People

(Reporter: paul, Assigned: paul)

References

Details

(Whiteboard: [fixed-in-fx-team][qa-])

Attachments

(2 files)

patch v1
1.00 KB, patch
rcampbell
: review+
Details | Diff | Splinter Review
patch v1.1
2.08 KB, patch
asa
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
When developing an addon, we have to deal with several possible instances of the Inspector (one per window). It would make our life easier if we could just listen to "highlighter-ready" and get the instance from there.
Attached patch patch v1 — — Splinter Review 

    
  

        Attachment #568436 -
        Flags: review?(rcampbell)

    
    

    
  
Comment on attachment 568436 [details] [diff] [review]
patch v1

ok

        Attachment #568436 -
        Flags: review?(rcampbell) → review+

    
  
Whiteboard: [land-in-fx-team]

    
    

    
  
Comment on attachment 568436 [details] [diff] [review]
patch v1

paul, we should create a test for this before landing. It's ok to tweak one of the initialization tests to check for the object on the observer.

should've asked for this sooner, sorry!

    
  
Priority: -- → P3
Whiteboard: [land-in-fx-team] → [waiting-for-unittest]

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v1.1
        — 
          — Splinter Review
      

    


  

    
  

        Attachment #575877 -
        Attachment description: with test → patch v1.1

    
  
Whiteboard: [waiting-for-unittest] → [land-in-fx-team]

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/ec7522554d45
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Assignee: nobody → paul
Status: NEW → ASSIGNED

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/ec7522554d45
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11

    
    

    
  
Comment on attachment 575877 [details] [diff] [review]
patch v1.1

I believe we should land this simple patch in aurora. It's for a new feature and will greatly-improve the add-on potential for the Highlighter. It is low-risk.

        Attachment #575877 -
        Flags: approval-mozilla-aurora?

    
  

        Attachment #575877 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Is there something QA can do to verify this fix?
Whiteboard: [fixed-in-fx-team] → [fixed-in-fx-team][qa?]

    
    

    
  
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #9)
> Is there something QA can do to verify this fix?

No, not really.

    
  
Whiteboard: [fixed-in-fx-team][qa?] → [fixed-in-fx-team][qa-]

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.