696149 - Add copies of Math constants and static methods to Number, for symmetry with float.

Status: VERIFIED FIXED

(Tamarin Graveyard :: Library, defect, P3)

Description

[Edwin Smith]

From Float spec 16.1:

Since we have copied the constants and methods from the Math object onto the float class as static methods (with new signatures), we should copy them onto the Number class as well (with unchanged signatures), so that programmers can write similar-looking code for the two types.

Comment 1

[Brent Baker]

Does this bug really block float/float4?

Comment 2

[Lars T Hansen]

Depends on whether you're asking me ("no") or PARB ("yes")...  You're right, I'll unlink it.

Comment 3

[Lars T Hansen]

Re-blocking float/float4 because it has been implemented and it's useful to keep track of it.

changeset:   6938:a50f9648c2d7
tag:         tip
user:        Lars T Hansen <[e-mail]>
date:        Mon Nov 21 10:34:23 2011 +0100
summary:     Copy constants and methods from Math to Number

Comment 4

[Brent Baker]

Attachment: Testmedia for Number

Comment 5

[Brent Baker]

changeset:   6943:51541d7832a0
tag:         tip
user:        Brent Baker <[e-mail]>
date:        Tue Nov 22 06:22:38 2011 -0500
summary:     Bug 696149: add testmedia for new Number static methods and constants.

Comment 6

[Brent Baker]

Attachment: API version testing

This patch adds some simple API version testing to make sure that only -api SWF_16+ is able to see the new methods and constants on the Number class.

This patch also contains a change to mimic how 'USES_SWFVERSION' is handled in the acceptance suite so that a single abc can be run multiple times using different -api switch values.

Comment 7

[Brent Baker]

(In reply to Brent Baker from comment #6)
> Created attachment 576152 [details] [diff] [review] [diff] [details] [review]
> API version testing

changeset:   6945:06df61d98f31
tag:         tip
user:        Brent Baker <[e-mail]>
date:        Tue Nov 22 10:09:00 2011 -0500
summary:     Bug 696149: add some API versioning testing around the new Number constants and static methods.

Comment 8

[Lars T Hansen]

Comment on attachment 576152 [details] [diff] [review]
API version testing

A comment to the effect that "20" is the API version that corresponds to SWF16 would be helpful, took me a little while to track that down.

Comment 9

[Tamarin Bot]

changeset: 6742:9c8b5cb0c79e
user:      Brent Baker <[e-mail]>
summary:   No bug: Reorganizing a Number testcase in preparation for landing bug 696149 which is in the float branch

http://hg.mozilla.org/tamarin-redux/rev/9c8b5cb0c79e

Comment 10

[Brent Baker]

changeset:   7095:95fcccdb79e6
tag:         tip
user:        Brent Baker <[e-mail]>
date:        Fri Dec 16 09:12:16 2011 -0500
summary:     Bug 696149: fix a couple of issues in the test media for Number.min and Number.log