696158 - Adapt expiration aggressivity to the distance from the history limit

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

Some time ago someone (I think jlebar?) complained about slow history on Android, we figured out he was highly over the expected limit (4 times higher) but it will take lots of hours before his database comes back to a valuable size, due to expiration limits.
We can adapt the expiration aggressivity based on how far we are from the history limit (we already know that!), that would be a nice touch.

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch v1.0

This is not easy to make a test for, but existing tests ensure expiration is not broken, and the patch is almost trivial.

Comment 2

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/990dff1b8831

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/990dff1b8831

Comment 4

[Justin Lebar (not reading bugmail)]

I'll see if this makes any difference on my phone...

Comment 5

[Marco Bonardo [:mak]]

well, this should speedup expiration by 10x in your case, so instead of the 100 hours of navigation I calculated before, should do work in 10 hours or so. Provided you use a nightly from tomorrow on.

Comment 6

[Justin Lebar (not reading bugmail)]

10 hours of use is a lot for a mobile browser!

Comment 7

[Marco Bonardo [:mak]]

(In reply to Justin Lebar [:jlebar] from comment #6)
> 10 hours of use is a lot for a mobile browser!

well, it will likely become usable BEFORE that time... 10 hours is time to reach perfection :)