Closed Bug 69616 Opened 23 years ago Closed 23 years ago

Edit sanity check?

Categories

(Bugzilla :: User Interface, defect, P4)

Product:
Bugzilla
Component:
User Interface
Version:
2.13
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Bugzilla 2.16

People

(Reporter: CodeMachine, Assigned: CodeMachine)

References

Details

Attachments

(1 file, 1 obsolete file)

Or I could do it the right way around.
1.11 KB, patch
justdave
: review+
justdave
: review+
Details | Diff | Splinter Review 
The footer has this line for priveleged users:

Edit prefs, parameters, sanity check, users, components, groups, keywords

How about splitting sanity check into its own action.  It has nothing to do with
editing.
See also bug 54556, "sanitycheck.cgi can be run by unprivileged accounts".

It doesn't seem to me like this should require its own group, but I don't know 
what the existing groups are, so maybe it does.
Target Milestone: --- → Bugzilla 2.16
Attached patch Fix. (obsolete) — — Splinter Review 

    
  
Keywords: patch, 
          
            review

    
  
Blocks: 91761

    
  
No longer blocks: 91761
Priority: -- → P4

    
  
Blocks: 91761

    
    

    
  
moving to Bugzilla product
Assignee: tara → myk
Component: Bugzilla → User Interface
Product: Webtools → Bugzilla
Version: other → 2.13

    
    

    
  
Comment on attachment 40273 [details] [diff] [review]
Or I could do it the right way around.

The line-breaks on this patch are all messed up for me. Can you please resubmit this?

    
  
Keywords: patch, 
          
            review

    
    

    
  
Taking ...
Assignee: myk → matty

    
  
Status: NEW → ASSIGNED
QA Contact: matty → jake

        Attachment #40271 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 40273 [details] [diff] [review]
Or I could do it the right way around.

r= justdave
no second review required.

checked in.

        Attachment #40273 -
        Flags: review+

    
    

    
  
hmm, can't mark the bug fixed from the attachment review page :-)
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
V. Fixed
Status: RESOLVED → VERIFIED
QA Contact: jake → default-qa

          You need to log in
          before you can comment on or make changes to this bug.