The default bug view has changed. See this FAQ.

Properties disabled in the css rule view should not be lost

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

9 Branch
Firefox 10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
1) Highlight node A
2) Disable a css property
3) Highlight node B
4) Highlight node A

The disabled css property is gone.  It should still be available.
(Assignee)

Updated

6 years ago
Depends on: 693887
(Assignee)

Updated

6 years ago
Priority: -- → P1
(Assignee)

Updated

6 years ago
Assignee: nobody → dcamp
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 572121 [details] [diff] [review]
WIP 1

Attached patch saves disabled properties in the inspector store, but the inspector store doesn't last the lifetime of the window, just as long as the store.

Still needs tests.
(Assignee)

Comment 2

6 years ago
Would it make sense for the inspector store to have page-lifetime instead of inspector-is-open lifetime?
the InspectorStore's used to restore the Highlighter state on tab switch. I guess it currently has an "inspector-is-open lifetime". Changing that to page-lifetime might get a bit weird and might change some of the restore behavior.

That feels like it could add a fair bit of complexity to managing the InspectorStore. I'd have to see an implementation, I guess.
Comment on attachment 572121 [details] [diff] [review]
WIP 1

looking good.
Attachment #572121 - Flags: feedback+
(Assignee)

Comment 5

6 years ago
Created attachment 572379 [details] [diff] [review]
v1

Adds a (somewhat grody) test.
Attachment #572121 - Attachment is obsolete: true
Attachment #572379 - Flags: review?(rcampbell)
Comment on attachment 572379 [details] [diff] [review]
v1

looks good. As for the test, I've seen grodier.
Attachment #572379 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/integration/fx-team/rev/c465f6d67aa9
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/c465f6d67aa9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
You need to log in before you can comment on or make changes to this bug.