696203 - [birch] Remove unused/broken mobile XPCOM components

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This gets rid of a bunch of XPCOM components that aren't currently doing anything in native Fennec and that (as far as I know) we don't have immediate plans to fix and use.

Some of these we will probably resurrect in a different form later on, but I think it is still useful to get rid of them for now.  Starting from a blank slate makes it easier to read and reason about the code, and helps establish a good baseline for performance and footprint numbers.

There might be some of these we actually want to keep, and I also probably missed some that could be removed (because I don't really know how and what all of our components do).  Feel free to suggest amendments.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 568502 [details] [diff] [review]
patch

AddonUpdateService.js - we want to keep addons, so this should stay, I think
AlertsService.js - we want to switch this to use native toaster alerts
DownloadManagerUI.js - we might actually need this for getting downloads to work. 
DownloadManagerUI.js - we should need this for getting our "download and open" behavior to work
SessionStore.js -  we want some form of session store to work. lets keep this for now.

AutoCompleteCache.js - kill
BrowserStartup.js - kill
LoginManager.js - kill (but make sure we are pulling in the toolkit nsLoginManager.js)

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 570094 [details] [diff] [review]
patch v2

* Looks like we don't need to worry about hiding the add-ons notification anymore. (BrowserStartup.js)

* Stylesheets are still functional

Comment 4

[Matt Brubeck (:mbrubeck)]

Pushed to birch, along with a follow-on change to comment out SessionStore.js because it is throwing a lot of exceptions to the log (r=dougt via IRC):
http://hg.mozilla.org/projects/birch/rev/5223f742314a

Filed bug 697858 to restore SessionStore.