696213 - Zombie compartments with Scriptish add-on and certain user-scripts for pages loaded at startup by SessionStore

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect)

Description

[Michael Kraft [:morac]]

I'm seeing Zombie Compartments with the Scriptish add-on installed and certain user scripts (ones that create elements in the host page) enabled if tabs that the scripts run in are loaded as part of SessionStore's session management.  For example on a reload of the browser.  Opening a tab and manually loading the page and then closing it does not result in a Zombie compartment.

This happens on the latest Minefield nightly load with only the Scriptish and Restartless Restart add-ons installed (nothing else).  Disabling Scriptish or the associated user scripts prevents the Zombie compartments.

The Zombie compartment for pages will stick around after numerous minimize cache actions unless the browser window is closed, in which case the zombie compartment will go away.

So I'm guessing there's some kind of weird interaction between SessionStore and and Scriptish resulting in zombie compartments.

Comment 1

[Justin Lebar (not reading bugmail)]

Triaging as MemShrink:P3, since this is due to an addon.

Comment 2

[Michael Kraft [:morac]]

Attachment: about:memory

Comment 3

[Nicholas Nethercote [inactive]]

Scriptish is a fork of GreaseMonkey.  Michael, do you know if the problem exists with GreaseMonkey as well?  I ask because AMO tells me that Scriptish has 43,000 users whereas GreaseMonkey has 3,000,000...

Comment 4

[Michael Kraft [:morac]]

I don't know.  Scriptish was rewritten to use Components and modules which attach to browser windows and tabs.  GreaseMonkey runs in each window.  While I have no proof, my guess is that GreaseMonkey probably would have this problem.

I haven't tested this for awhile though.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Adding a couple of Scriptish devs.

Comment 6

[Nils Maier [:nmaier]]

Michael, can you post more detailed steps to reproduce, like what user scripts will make the browser say "BRAINS!!!" when restoring what sites?

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

It's been a while and there are no STR. Please reopen if you have a way to replicate this problem, either with Scriptish of GreaseMonkey.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

* or