696232 - Use an enum to pass flag value to InitArrayElements

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Right now we pass a bool.  This should be an enum, per modern SM style.

Comment 1

[Terrence Cole [:terrence]]

Attachment: v1: Trivial implementation.

If you have clearer/better/more-canonical names, please let me know.  Otherwise this is absurdly trivial.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 570007 [details] [diff] [review]
v1: Trivial implementation.

Scratch that.  I forgot to change the rest of the signature.

Comment 3

[Terrence Cole [:terrence]]

Attachment: v2: Also fix the return type.

This should be trivial to review.

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 573021 [details] [diff] [review]
v2: Also fix the return type.

Review of attachment 573021 [details] [diff] [review]:
-----------------------------------------------------------------

Slight nits, looks fine otherwise.

::: js/src/jsarray.cpp
@@ +1764,5 @@
>  
> +enum ShouldUpdateTypes
> +{
> +    DoUpdateTypes,
> +    DoNotUpdateTypes

I'd name these UpdateTypes and DontUpdateTypes.  And if you initialized UpdateTypes to true and DontUpdateTypes to false, you probably could get away without changing any of the uses of variables of these types, either -- only the places where the enum is passed.  I've seen Luke do this at least one other place before.

Comment 5

[Terrence Cole [:terrence]]

Attachment: v3: With review feedback.

Will push to try once it's unbroken.

Comment 6

[Terrence Cole [:terrence]]

Attachment: v4: because I can't read.

Comment 7

[Terrence Cole [:terrence]]

https://tbpl.mozilla.org/?tree=Try&rev=3ccdad371c1e

Comment 8

[Terrence Cole [:terrence]]

Prior try run looks like it got busted by unrelated problems on macos, and this needed a merge this morning: retrying.

https://tbpl.mozilla.org/?tree=Try&rev=91d9b57fd410

Comment 9

[Terrence Cole [:terrence]]

https://tbpl.mozilla.org/?tree=Try&rev=00447b677920

Comment 10

[Terrence Cole [:terrence]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/646f4a4d58ea

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/646f4a4d58ea