Regression: Processing.js Performance Tests don't work

VERIFIED FIXED in Firefox 9

Status

()

Firefox
Developer Tools
P1
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: dmandelin, Assigned: past)

Tracking

({regression, verified-aurora, verified-beta})

Trunk
Firefox 10
x86_64
Windows 7
regression, verified-aurora, verified-beta
Points:
---

Firefox Tracking Flags

(firefox9+ fixed, firefox10+ fixed)

Details

(Whiteboard: [qa!][testcase: comment 3], URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
[18:23:05.014] uncaught exception: TypeError: format.replace is not a function

9/20 nightly: works
9/21 nightly: doesn't work

http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=09%2F19%2F2011&enddate=09%2F21%2F2011
(Reporter)

Comment 1

6 years ago
I bisected this to http://hg.mozilla.org/mozilla-central/rev/8e3e1c5f348d

It appears that that patch introduces a call to |format.replace| on some paths called for console logging functions, and |format.replace| doesn't exist.
Blocks: 614586
(Reporter)

Updated

6 years ago
Assignee: general → nobody
Component: JavaScript Engine → Developer Tools
Product: Core → Firefox
QA Contact: general → developer.tools
How can I reproduce this failure?
(In reply to Panos Astithas [:past] from comment #2)
> How can I reproduce this failure?

1) go here: http://scotland.proximity.on.ca/dxr/tmp/processing-js/test/perf/
2) click start
Assignee: nobody → past
Status: NEW → ASSIGNED
Created attachment 569007 [details] [diff] [review]
Simple fix

A simple fix with a test.
Attachment #569007 - Flags: review?(ddahl)

Comment 5

6 years ago
Try run for 7e1cb1fada01 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7e1cb1fada01
Results (out of 155 total builds):
    success: 152
    warnings: 2
    failure: 1
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/pastithas@mozilla.com-7e1cb1fada01

Updated

6 years ago
Attachment #569007 - Flags: review?(ddahl) → review+
Attachment #569007 - Flags: review?(Olli.Pettay)

Updated

6 years ago
Attachment #569007 - Flags: review?(Olli.Pettay) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/7ba9a146e1e8
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]

Updated

6 years ago
Priority: -- → P1

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/7ba9a146e1e8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 10
Duplicate of this bug: 702928
Comment on attachment 569007 [details] [diff] [review]
Simple fix

We forgot to get this into 9 when it was in aurora, can we get it into beta now?
Attachment #569007 - Flags: approval-mozilla-beta?
Whiteboard: [qa+][testcase: comment 3]

Comment 10

6 years ago
Comment on attachment 569007 [details] [diff] [review]
Simple fix

[triage comment]
Approved for beta. Please land today asap.
Attachment #569007 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
http://hg.mozilla.org/releases/mozilla-beta/rev/3d16e65f9481
(In reply to Rob Campbell [:rc] (robcee) from comment #11)
> http://hg.mozilla.org/releases/mozilla-beta/rev/3d16e65f9481

Can we change status-firefox9 to fixed?
status-firefox10: affected → fixed
status-firefox9: affected → fixed
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20100101 Firefox/9.0 (beta 3)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a2) Gecko/20111122 Firefox/10.0a2
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:11.0a1) Gecko/20111122 Firefox/11.0a1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111122 Firefox/11.0a1

Verified using the steps from comment #3: pressing "Start" started the tests run, although some tests failed. Should a separate bug be logged for that?
Status: RESOLVED → VERIFIED
Keywords: verified-aurora, verified-beta
Whiteboard: [qa+][testcase: comment 3] → [qa!][testcase: comment 3]
(In reply to Mihaela Velimiroviciu [QA] from comment #13)
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20100101 Firefox/9.0 (beta
> 3)
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a2) Gecko/20111122 Firefox/10.0a2
> Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:11.0a1) Gecko/20111122
> Firefox/11.0a1
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111122 Firefox/11.0a1
> 
> Verified using the steps from comment #3: pressing "Start" started the tests
> run, although some tests failed. Should a separate bug be logged for that?

no. If the processing team finds bugs in that version, they should open new bugs for the regressions. Thanks for verifying.
You need to log in before you can comment on or make changes to this bug.