What happened to the arguments element IC ?

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: evilpie, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
My HG skill fail me a bit, but apparently since Type Inference, somebody removed the call to attachArguments in GetElementIC::update. I guess this has been disabled because TI can optimize arguments access. But this might still be a win, because from what i remember this optimization doesn't work cross-functions.
(Reporter)

Updated

6 years ago
Summary: What happend to the arguments element IC ? → What happened to the arguments element IC ?
Looked around a bit ('hg log file -p' for a complete history of changes to a file), and the arguments IC has never actually been enabled.  Here is the original landing of bug 616744:

https://hg.mozilla.org/mozilla-central/rev/da50621162f3

attachArguments is defined but is not called anywhere.
Depends on: 703721
(Reporter)

Comment 2

6 years ago
Brian activated the IC in Bug 703721.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.