S390 xptc invoke broken

RESOLVED FIXED in mozilla10

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla10
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
I'm getting SIGILL on S390 when running xpcshell during packaging, when generating startup cache. What seems to happen is that some compiler optimizations are breaking the NS_InvokeByIndex assembly. Compiling xptcinvoke_linux_s390.cpp without optimization makes xptcinvoke work.

However, the function call convention on s390 is pretty straightforward, and can actually be implemented in pure C like we have on e.g. x86-64 or ARM.
(Assignee)

Comment 1

6 years ago
Created attachment 568673 [details] [diff] [review]
Reimplement NS_InvokeByIndex in C on S390 Linux
Attachment #568673 - Flags: review?(benjamin)

Comment 2

6 years ago
Comment on attachment 568673 [details] [diff] [review]
Reimplement NS_InvokeByIndex in C on S390 Linux

rubberstamping port-specific code, I'm not really interested in reviewing it anyway.
Attachment #568673 - Flags: review?(benjamin) → review+
(Assignee)

Updated

6 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a75f440117c9
Whiteboard: [inbound]

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/a75f440117c9
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.