Last Comment Bug 696393 - S390 xptc invoke broken
: S390 xptc invoke broken
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: Other Linux
: -- normal (vote)
: mozilla10
Assigned To: Mike Hommey [:glandium]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-21 08:54 PDT by Mike Hommey [:glandium]
Modified: 2011-12-02 06:44 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Reimplement NS_InvokeByIndex in C on S390 Linux (2.56 KB, patch)
2011-10-21 09:17 PDT, Mike Hommey [:glandium]
benjamin: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2011-10-21 08:54:25 PDT
I'm getting SIGILL on S390 when running xpcshell during packaging, when generating startup cache. What seems to happen is that some compiler optimizations are breaking the NS_InvokeByIndex assembly. Compiling xptcinvoke_linux_s390.cpp without optimization makes xptcinvoke work.

However, the function call convention on s390 is pretty straightforward, and can actually be implemented in pure C like we have on e.g. x86-64 or ARM.
Comment 1 Mike Hommey [:glandium] 2011-10-21 09:17:36 PDT
Created attachment 568673 [details] [diff] [review]
Reimplement NS_InvokeByIndex in C on S390 Linux
Comment 2 Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg] 2011-10-26 09:43:56 PDT
Comment on attachment 568673 [details] [diff] [review]
Reimplement NS_InvokeByIndex in C on S390 Linux

rubberstamping port-specific code, I'm not really interested in reviewing it anyway.
Comment 4 Ed Morley [:emorley] 2011-10-28 04:39:56 PDT
https://hg.mozilla.org/mozilla-central/rev/a75f440117c9

Note You need to log in before you can comment on or make changes to this bug.