Closed
Bug 696398
Opened 13 years ago
Closed 13 years ago
Need an api to analyze panning performance
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: taras.mozilla, Assigned: jrmuizel)
References
Details
Attachments
(1 file, 1 obsolete file)
4.85 KB,
patch
|
ajuma
:
review+
BenWa
:
feedback+
|
Details | Diff | Splinter Review |
We need to Start() and Stop() a panning operation. Once stopped we should get a histogram of paint times.
Joel, this is the bug I mentioned where we were talking about a low level API to help measure panning for Fennec-native.
Blocks: native_droid_panning
Comment 2•13 years ago
|
||
would we need a separate bug for zooming?
Comment 3•13 years ago
|
||
can I get an idea of what this API will look like and what I could expect from it? Maybe just some example code of how to use it and some made up (yet moderately realistic) results?
Comment 4•13 years ago
|
||
can we get this sample data? we are building tools around this and it would be nice to work with some sample data. Thanks!
Assignee | ||
Comment 5•13 years ago
|
||
I'll try to get this working this week.
Assignee | ||
Comment 6•13 years ago
|
||
This adds a startFrameTimeRecording() and stopFrameTimeRecording() to DOMWindowUtils. stopFrameTimeRecording() returns an array of frame times in milliseconds.
I was talking with :pcwalton about this last night and he was worried that on birch, gecko might not have access to what's being drawn now as a result of the patch queue he landed last night (on birch). Can you guys confirm whether or not that is the case?
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Clint Talbert ( :ctalbert ) from comment #7)
> I was talking with :pcwalton about this last night and he was worried that
> on birch, gecko might not have access to what's being drawn now as a result
> of the patch queue he landed last night (on birch). Can you guys confirm
> whether or not that is the case?
Correct. Something like this API will need to be added to the Java UI.
Assignee | ||
Comment 9•13 years ago
|
||
Attachment #573273 -
Attachment is obsolete: true
Attachment #577793 -
Flags: feedback?(bgirard)
Comment 10•13 years ago
|
||
Comment on attachment 577793 [details] [diff] [review]
Add the api
Review of attachment 577793 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/Layers.cpp
@@ +576,5 @@
> +
> +nsTArray<float>
> +LayerManager::StopFrameTimeRecording()
> +{
> + mLastFrameTime = TimeStamp();
I would add a comment about how 'TimeStamp()' is the "null" moment that you're using to mark that it's stopped.
Attachment #577793 -
Flags: feedback?(bgirard) → feedback+
Assignee | ||
Updated•13 years ago
|
Attachment #577793 -
Flags: review?(ajuma)
Comment 11•13 years ago
|
||
Comment on attachment 577793 [details] [diff] [review]
Add the api
Review of attachment 577793 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/Layers.cpp
@@ +570,5 @@
> +void
> +LayerManager::PostPresent()
> +{
> + if (!mLastFrameTime.IsNull())
> + mFrameTimes.AppendElement((TimeStamp::Now() - mLastFrameTime).ToMilliseconds());
Update mLastFrameTime here.
Attachment #577793 -
Flags: review?(ajuma) → review+
Comment 12•13 years ago
|
||
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•