696433 - Improve link rel scanning for favicons

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement, P4)

Description

[Gian-Carlo Pascutto [:gcp]]

rel.indexOf("icon") is not a very good test. It will match for <link rel="rubicon"> for instance.
There's a proper algorithm described here:http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#rel-icon

We can also support apple-touch-icon like we did at http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/browser-ui.js#1027

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch takes some code from desktop and sanitizes the link rel string a bit _before_ sending it to Java. Mainly because doing the same code in Java sucks!

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/393cfb93e80d

Comment 3

[Aaron Train [:aaronmt]]

Galaxy SII (Android 2.3.4)
20111208060054
http://hg.mozilla.org/integration/mozilla-inbound/rev/b0f8871174a5

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #3)
> Galaxy SII (Android 2.3.4)
> 20111208060054
> http://hg.mozilla.org/integration/mozilla-inbound/rev/b0f8871174a5

Mis-fire. This is the wrong cset and the code is not on m-c yet :)

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/393cfb93e80d