Closed Bug 696433 Opened 8 years ago Closed 8 years ago

Improve link rel scanning for favicons

Categories

(Firefox for Android :: General, enhancement, P4)

ARM
Android
enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: gcp, Assigned: mfinkle)

Details

Attachments

(1 file)

rel.indexOf("icon") is not a very good test. It will match for <link rel="rubicon"> for instance.
There's a proper algorithm described here:http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#rel-icon

We can also support apple-touch-icon like we did at http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/browser-ui.js#1027
Severity: normal → enhancement
Priority: -- → P4
Assignee: nobody → lucasr.at.mozilla
Summary: Improve handling for favicons → Improve link rel scanning for favicons
Attached patch patchSplinter Review
This patch takes some code from desktop and sanitizes the link rel string a bit _before_ sending it to Java. Mainly because doing the same code in Java sucks!
Assignee: lucasr.at.mozilla → mark.finkle
Attachment #579958 - Flags: review?(mbrubeck)
Attachment #579958 - Flags: review?(mbrubeck) → review+
Galaxy SII (Android 2.3.4)
20111208060054
http://hg.mozilla.org/integration/mozilla-inbound/rev/b0f8871174a5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
(In reply to Aaron Train [:aaronmt] from comment #3)
> Galaxy SII (Android 2.3.4)
> 20111208060054
> http://hg.mozilla.org/integration/mozilla-inbound/rev/b0f8871174a5

Mis-fire. This is the wrong cset and the code is not on m-c yet :)
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
https://hg.mozilla.org/mozilla-central/rev/393cfb93e80d
Status: NEW → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.