696550 - Reset favicon when loading a new document

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: patch

STR:
1) Load a site with a favicon (eg http://slashdot.org)
2) Load a site without a favicon (eg about:support)

Expected results:
No favicon displayed after 2)

Results:
The favicon from 1) is still displayed.

This is because DOMLinkAdded is never called.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 568847 [details] [diff] [review]
patch

onLocationChange seems like good place to reset the favicon.

Comment 2

[[:fabrice] Fabrice Desré]

pushed:
http://hg.mozilla.org/projects/birch/rev/d80bb047fca2

Comment 3

[Aaron Train [:aaronmt]]

Filed bug 697070 for a similar issue with this 'tab menu' drop down that has appeared overnight

Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111025 Firefox/10.0a1 Fennec/10.0a1

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch 2

In the current implementation, the favicon is reset in the browser toolbar. This is not reset with the tab. So when there is a location change, the favicon is updated only if the webpage has a "link rel=shortcut-icon" present it.

We have added a check to download default favicon from the domain (domain/favicon.ico), if the Tab's favicon is null. This wouldn't happen when we open google.com from about:start, as Tab's favicon holds about:start's favicon.

This patch resets the Tab's favicon when there is a location change.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/b2d46075f3a2

Note: Any new patches should be on new bugs. This bug is closed.