Last Comment Bug 696603 - "(new MozBlobBuilder).append(null);" crashes
: "(new MozBlobBuilder).append(null);" crashes
Status: RESOLVED FIXED
: assertion, crash, testcase
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- critical (vote)
: mozilla10
Assigned To: Kyle Huey [:khuey] (khuey@mozilla.com)
:
Mentors:
Depends on:
Blocks: 326633
  Show dependency treegraph
 
Reported: 2011-10-22 13:07 PDT by Jesse Ruderman
Modified: 2011-10-25 21:57 PDT (History)
3 users (show)
khuey: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (crashes Firefox when loaded) (56 bytes, text/html)
2011-10-22 13:07 PDT, Jesse Ruderman
no flags Details
stacks (40.30 KB, text/plain)
2011-10-22 13:08 PDT, Jesse Ruderman
no flags Details
Patch (1.58 KB, patch)
2011-10-24 06:41 PDT, Kyle Huey [:khuey] (khuey@mozilla.com)
jonas: review+
christian: approval‑mozilla‑aurora-
christian: approval‑mozilla‑beta-
Details | Diff | Splinter Review

Description Jesse Ruderman 2011-10-22 13:07:49 PDT
Created attachment 568902 [details]
testcase (crashes Firefox when loaded)

###!!! ASSERTION: Er, what?: 'obj', file content/base/src/nsDOMBlobBuilder.cpp, line 375

###!!! ASSERTION: bad param: 'aJSObj', file js/xpconnect/src/nsXPConnect.cpp, line 1468

###!!! ASSERTION: bad param: 'obj', file js/xpconnect/src/XPCWrappedNative.cpp, line 1594

Crash [@ nsXPConnect::GetNativeOfWrapper]
  (Opt: bp-aa135286-3026-410b-a80d-c289a2111022)
Comment 1 Jesse Ruderman 2011-10-22 13:08:44 PDT
Created attachment 568903 [details]
stacks
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-10-24 06:41:00 PDT
Created attachment 569045 [details] [diff] [review]
Patch
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-10-24 13:02:19 PDT
https://hg.mozilla.org/mozilla-central/rev/58eb2ebcc7d2
Comment 4 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-10-24 13:04:39 PDT
Comment on attachment 569045 [details] [diff] [review]
Patch

This is a pretty simple fix.
Comment 5 christian 2011-10-25 20:16:47 PDT
---------------------------------[ Triage Comment ]---------------------------------

Though it is a simple fix, there were only 2 crashes in the last week across all versions so the reward side of the equation doesn't seem to be there. Let's let this come up through the normal process.
Comment 6 Jesse Ruderman 2011-10-25 21:57:10 PDT
At least one of those crashes was me ;)

Note You need to log in before you can comment on or make changes to this bug.