696665 - nsJSContext::JSObjectFromInterface should take a JSObject scope parameter

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Mounir Lamouri (:mounir)]

Comment on attachment 568966 [details] [diff] [review]
Patch v1

Review of attachment 568966 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSEnvironment.cpp
@@ +1872,5 @@
>  #endif
>  
>    JSAutoRequest ar(mContext);
>    JSObject* target = nsnull;
> +  nsresult rv = JSObjectFromInterface(aTarget, static_cast<JSObject*>(aScope),

Why are you calling static_cast here? aScope is already a JSObject*, isn't it?

@@ +1978,5 @@
>    JSAutoRequest ar(mContext);
>  
>    // Get the jsobject associated with this target
>    JSObject *target = nsnull;
> +  nsresult rv = JSObjectFromInterface(aTarget, static_cast<JSObject*>(aScope),

ditto

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I'm afraid not; they are turned into JSObjects in the bugs this one blocks. I can do them in the opposite direction if you prefer.

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 568966 [details] [diff] [review]
Patch v1

Review of attachment 568966 [details] [diff] [review]:
-----------------------------------------------------------------

Oups, I didn't see this was a different method.

Looks good then.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/6b05ed1c92ae