Closed
Bug 696665
Opened 13 years ago
Closed 13 years ago
nsJSContext::JSObjectFromInterface should take a JSObject scope parameter
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
3.91 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #568966 -
Flags: review?(mounir)
Flags: in-testsuite-
Comment 1•13 years ago
|
||
Comment on attachment 568966 [details] [diff] [review] Patch v1 Review of attachment 568966 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/nsJSEnvironment.cpp @@ +1872,5 @@ > #endif > > JSAutoRequest ar(mContext); > JSObject* target = nsnull; > + nsresult rv = JSObjectFromInterface(aTarget, static_cast<JSObject*>(aScope), Why are you calling static_cast here? aScope is already a JSObject*, isn't it? @@ +1978,5 @@ > JSAutoRequest ar(mContext); > > // Get the jsobject associated with this target > JSObject *target = nsnull; > + nsresult rv = JSObjectFromInterface(aTarget, static_cast<JSObject*>(aScope), ditto
Assignee | ||
Comment 2•13 years ago
|
||
I'm afraid not; they are turned into JSObjects in the bugs this one blocks. I can do them in the opposite direction if you prefer.
Comment 3•13 years ago
|
||
Comment on attachment 568966 [details] [diff] [review] Patch v1 Review of attachment 568966 [details] [diff] [review]: ----------------------------------------------------------------- Oups, I didn't see this was a different method. Looks good then.
Attachment #568966 -
Flags: review?(mounir) → review+
Assignee | ||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6b05ed1c92ae
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•