696731 - Properties context menu option in Bookmarks Manager does nothing when the embedded properties pane is already open

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[[e-mail]]

I came up with a number of potentially acceptable behaviours:
* Toggle the More/Fewer button if it is visible
* Hide the menuitem when the properties are displayed
* Turn the menuitem into a checkbox toggle that hides the properties again
  (thus making the splitter accessible)
Or maybe you could think of something better.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

* Toggling the More button is unexpected/inconsistent with what Properties does when the pane is collapsed, so this is not a good option.
* Hiding/disabling the menuitem is a valid option.
* Turning it into a checkbox doesn't sound like an improvement to me.

I'd suggest to just focus the first text field (Name); basically the same as pressing Tab. That will select the contents of the text field, which is quite visible (unless the field is empty). We could even do that unconditionally.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Attachment: focus Name [Checkin: comments 3 and 5]

Every item in the BM (except for separators, which do not have Properties enabled) has at least Name, which is always first. The attached patch focuses the corresponding text box. On Windows, the text inside the box will be selected, too; on Linux the activation is not so obvious (only focus ring and caret appear) but still enough IMHO.

Not taking until I get at least f+.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 569716 [details] [diff] [review]
focus Name [Checkin: comments 3 and 5]

http://hg.mozilla.org/comm-central/rev/806affdb379c

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 569716 [details] [diff] [review]
focus Name [Checkin: comments 3 and 5]

Base bug 674208 already landed on Aurora and Beta, and this is a small and safe improvement to that one. Probably too late for Beta, so just asking for Aurora approval.

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 569716 [details] [diff] [review]
focus Name [Checkin: comments 3 and 5]

http://hg.mozilla.org/releases/comm-aurora/rev/8067ee8641fc