Closed Bug 696833 Opened 8 years ago Closed 8 years ago

Ux Designs for Awesome Screen

Categories

(Firefox for Android :: General, defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: elan, Assigned: lucasr)

Details

Attachments

(7 files)

Meta bug.
More polished mocks and assets are on the way, but this should be enough to start with.
Taking this bug now that we have UI spec for it.
Assignee: madhava → lucasr.at.mozilla
Mark (or anyone with different Android devices), could you install this apk on your device and send a screenshot? Just want to test the patch at least in one different device to make sure it works as expected.

APK: http://www.box.net/shared/z8ihpkj5gg2tf7noaaa1
Attachment #573209 - Flags: review?(mark.finkle) → review+
Comment on attachment 573210 [details] [diff] [review]
(2/2) Implement dynamically coloured tabs in AwesomeBar

>+    static {
>+        // We wan to use the same color on the list items (in pressed state)

We want
Attachment #573210 - Flags: review?(mark.finkle) → review+
Follow-up bugs:

 - Add 'Go' button to AwesomeBar text entry 
   https://bugzilla.mozilla.org/show_bug.cgi?id=701329

 - Show star on urls that are bookmarks in AwesomeBar screen
   https://bugzilla.mozilla.org/show_bug.cgi?id=701330
Pushed:
http://hg.mozilla.org/projects/birch/rev/74eee623c0a0
http://hg.mozilla.org/projects/birch/rev/c5f8e6042fb8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I was looking for coloring the browser toolbar with the system color. I found this: android.R.attr.textColorHighlight (ARGB value). This might work for getting the color I guess.
ContextThemeWrapper ctw = new ContextThemeWrapper(mContext, android.R.style.TextAppearance);
TypedArray ta = ctw.getTheme().obtainStyledAttributes(new int[] { android.R.attr.textColorHighlight });
int color = ta.getColor(ta.getIndex(0), 0);

The above code gives the color of orange #FFFF9200 on stock gingerbread (Nexus S),
and #FF428EBA on Samsung Galaxy S2 (their blue) color.

I feel this would be a clear code and the perfect color to use.
The selected tab text color is black instead of white on the latest Nightly build.

--
Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20111111
Firefox/10.0a1 Fennec/10.0a1
Devices: Motorola Droid 2
OS: Android 2.3.3
backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
20111114041052
http://hg.mozilla.org/projects/birch/rev/859ecdfe0168
Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
You need to log in before you can comment on or make changes to this bug.