Ux Designs for Awesome Screen

VERIFIED FIXED

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
10 months ago

People

(Reporter: elan, Assigned: lucasr)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(7 attachments)

(Reporter)

Description

6 years ago
Meta bug.
Created attachment 569498 [details]
mockup of awesomescreen interactions

More polished mocks and assets are on the way, but this should be enough to start with.
Created attachment 571341 [details]
More detailed mocks
Created attachment 571342 [details]
Specs (based on 320px wide phone)
(Assignee)

Comment 4

6 years ago
Taking this bug now that we have UI spec for it.
Assignee: madhava → lucasr.at.mozilla
(Assignee)

Comment 5

6 years ago
Created attachment 573209 [details] [diff] [review]
(1/2) Change style of awesome bar entry as per design
Attachment #573209 - Flags: review?(mark.finkle)
(Assignee)

Comment 6

6 years ago
Created attachment 573210 [details] [diff] [review]
(2/2) Implement dynamically coloured tabs in AwesomeBar
Attachment #573210 - Flags: review?(mark.finkle)
(Assignee)

Comment 7

6 years ago
Mark (or anyone with different Android devices), could you install this apk on your device and send a screenshot? Just want to test the patch at least in one different device to make sure it works as expected.

APK: http://www.box.net/shared/z8ihpkj5gg2tf7noaaa1
(Assignee)

Comment 8

6 years ago
Created attachment 573215 [details]
Screenshot on a Galaxy S
Attachment #573209 - Flags: review?(mark.finkle) → review+
Comment on attachment 573210 [details] [diff] [review]
(2/2) Implement dynamically coloured tabs in AwesomeBar

>+    static {
>+        // We wan to use the same color on the list items (in pressed state)

We want
Attachment #573210 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 10

6 years ago
Follow-up bugs:

 - Add 'Go' button to AwesomeBar text entry 
   https://bugzilla.mozilla.org/show_bug.cgi?id=701329

 - Show star on urls that are bookmarks in AwesomeBar screen
   https://bugzilla.mozilla.org/show_bug.cgi?id=701330
(Assignee)

Comment 11

6 years ago
Pushed:
http://hg.mozilla.org/projects/birch/rev/74eee623c0a0
http://hg.mozilla.org/projects/birch/rev/c5f8e6042fb8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I was looking for coloring the browser toolbar with the system color. I found this: android.R.attr.textColorHighlight (ARGB value). This might work for getting the color I guess.
ContextThemeWrapper ctw = new ContextThemeWrapper(mContext, android.R.style.TextAppearance);
TypedArray ta = ctw.getTheme().obtainStyledAttributes(new int[] { android.R.attr.textColorHighlight });
int color = ta.getColor(ta.getIndex(0), 0);

The above code gives the color of orange #FFFF9200 on stock gingerbread (Nexus S),
and #FF428EBA on Samsung Galaxy S2 (their blue) color.

I feel this would be a clear code and the perfect color to use.
Created attachment 573812 [details]
screenshot on Motorola Droid 2

The selected tab text color is black instead of white on the latest Nightly build.

--
Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20111111
Firefox/10.0a1 Fennec/10.0a1
Devices: Motorola Droid 2
OS: Android 2.3.3
backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
20111114041052
http://hg.mozilla.org/projects/birch/rev/859ecdfe0168
Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.