Rename class CodeGenerator to BytecodeEmitter

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
Recently I renamed JSCodeGenerator to js::CodeGenerator. This caused it to be impossible to merge tip to IonMonkey, because IM has a class CodeGenerator of its own.

So let's try BytecodeEmitter.

This patch is big mostly because the almost universal name for variables of type CodeGenerator* is "cg".

Taking the opportunity to change CodeGenerator macros to methods.
(Assignee)

Comment 1

6 years ago
Created attachment 569178 [details] [diff] [review]
Part 1 - Rename js::CodeGenerator to js::BytecodeEmitter, v1
Assignee: general → jorendorff
(Assignee)

Updated

6 years ago
Attachment #569178 - Flags: review?(dvander)
(Assignee)

Comment 2

6 years ago
Created attachment 569179 [details] [diff] [review]
Part 2 - Change CG_ macros to BytecodeEmitter methods, v1
Attachment #569179 - Flags: review?(dvander)
(Assignee)

Comment 3

6 years ago
Created attachment 569182 [details] [diff] [review]
Part 3 - Rename PopStatementCG and NewScriptFromCG
Attachment #569182 - Flags: review?(dvander)
Attachment #569178 - Flags: review?(dvander) → review+
Comment on attachment 569179 [details] [diff] [review]
Part 2 - Change CG_ macros to BytecodeEmitter methods, v1

Review of attachment 569179 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #569179 - Flags: review?(dvander) → review+
Attachment #569182 - Flags: review?(dvander) → review+
(Assignee)

Comment 5

6 years ago
1 - https://hg.mozilla.org/integration/mozilla-inbound/rev/c479d9c16a80
2 - https://hg.mozilla.org/integration/mozilla-inbound/rev/2518a604fb45
3 - https://hg.mozilla.org/integration/mozilla-inbound/rev/8aeb207c9a2f

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/c479d9c16a80
https://hg.mozilla.org/mozilla-central/rev/2518a604fb45
https://hg.mozilla.org/mozilla-central/rev/8aeb207c9a2f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.