Closed Bug 696876 Opened 8 years ago Closed 8 years ago

Rename class CodeGenerator to BytecodeEmitter

Categories

(Core :: JavaScript Engine, defect)

Other Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(3 files)

Recently I renamed JSCodeGenerator to js::CodeGenerator. This caused it to be impossible to merge tip to IonMonkey, because IM has a class CodeGenerator of its own.

So let's try BytecodeEmitter.

This patch is big mostly because the almost universal name for variables of type CodeGenerator* is "cg".

Taking the opportunity to change CodeGenerator macros to methods.
Assignee: general → jorendorff
Attachment #569178 - Flags: review?(dvander)
Attachment #569178 - Flags: review?(dvander) → review+
Comment on attachment 569179 [details] [diff] [review]
Part 2 - Change CG_ macros to BytecodeEmitter methods, v1

Review of attachment 569179 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #569179 - Flags: review?(dvander) → review+
Attachment #569182 - Flags: review?(dvander) → review+
You need to log in before you can comment on or make changes to this bug.