696876 - Rename class CodeGenerator to BytecodeEmitter

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Recently I renamed JSCodeGenerator to js::CodeGenerator. This caused it to be impossible to merge tip to IonMonkey, because IM has a class CodeGenerator of its own.

So let's try BytecodeEmitter.

This patch is big mostly because the almost universal name for variables of type CodeGenerator* is "cg".

Taking the opportunity to change CodeGenerator macros to methods.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Part 1 - Rename js::CodeGenerator to js::BytecodeEmitter, v1

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Part 2 - Change CG_ macros to BytecodeEmitter methods, v1

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Part 3 - Rename PopStatementCG and NewScriptFromCG

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 569179 [details] [diff] [review]
Part 2 - Change CG_ macros to BytecodeEmitter methods, v1

Review of attachment 569179 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 5

[Jason Orendorff [:jorendorff]]

1 - https://hg.mozilla.org/integration/mozilla-inbound/rev/c479d9c16a80
2 - https://hg.mozilla.org/integration/mozilla-inbound/rev/2518a604fb45
3 - https://hg.mozilla.org/integration/mozilla-inbound/rev/8aeb207c9a2f

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c479d9c16a80
https://hg.mozilla.org/mozilla-central/rev/2518a604fb45
https://hg.mozilla.org/mozilla-central/rev/8aeb207c9a2f