User Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111012 Firefox/8.0 SeaMonkey/2.5 Build ID: 20111012194554 Actual results: The function nsJAR::GetCertificatePrincipal() uses a string transformation, which is not necessary. see comment https://bugzilla.mozilla.org/show_bug.cgi?id=296795#c39
Created attachment 569337 [details] [diff] [review] optimized string handling Work without local copy of aFilename.
Try run for b8ca354cf381 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=b8ca354cf381 Results (out of 190 total builds): success: 184 warnings: 6 Builds available at http://firstname.lastname@example.org
Did you mean to request review on this? tglek is probably the best choice.
Comment on attachment 569337 [details] [diff] [review] optimized string handling Hallo I have created a followup and tested my new try server account. The result summary https://tbpl.mozilla.org/?tree=Try&rev=b8ca354cf381 is empty!? But the comment 2 and the log files on the ftp server looks good. The firefox build runs fine on Linux.
Comment on attachment 569337 [details] [diff] [review] optimized string handling thank you
Please could you add commit message + author info, along the lines of http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed Thanks :-)
Created attachment 570251 [details] [diff] [review] better string handling in nsJAR.cpp Same patch as attachment 569337 [details] [diff] [review] with commit headers inside. # HG changeset patch # User Wolfgang Germund <email@example.com> # Date 1319809381 -7200 # Node ID bc922174efa4cc6b29693d0fbba3aa652a832980 # Parent 6ec5b28142d10d83046bdce764fbc1fe3598d4be Bug 697061: better string handling in nsJAR.cpp