Status
People
(Reporter: wolfgang, Assigned: wolfgang)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment, 1 obsolete attachment)
|
3.78 KB,
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111012 Firefox/8.0 SeaMonkey/2.5 Build ID: 20111012194554 Actual results: The function nsJAR::GetCertificatePrincipal() uses a string transformation, which is not necessary. see comment https://bugzilla.mozilla.org/show_bug.cgi?id=296795#c39
|
(Assignee) | |
Updated•7 years ago
|
||
Component: File Handling → File Handling
Depends on: 296795
OS: Linux → All
Product: Firefox → Core
Hardware: x86 → All
|
|
(Assignee) | |
Comment 1•7 years ago
|
||
Created attachment 569337 [details] [diff] [review] optimized string handling Work without local copy of aFilename.
|
||
Comment 2•7 years ago
|
||
Try run for b8ca354cf381 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=b8ca354cf381
Results (out of 190 total builds):
success: 184
warnings: 6
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/wolfgang@germund.name-b8ca354cf381
|
||
Comment 3•7 years ago
|
||
Did you mean to request review on this? tglek is probably the best choice.
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
Comment on attachment 569337 [details] [diff] [review] optimized string handling Hallo I have created a followup and tested my new try server account. The result summary https://tbpl.mozilla.org/?tree=Try&rev=b8ca354cf381 is empty!? But the comment 2 and the log files on the ftp server looks good. The firefox build runs fine on Linux.
Attachment #569337 -
Flags: review?(tglek)
|
||
Comment 5•7 years ago
|
||
Comment on attachment 569337 [details] [diff] [review] optimized string handling thank you
Attachment #569337 -
Flags: review?(tglek) → review+
|
|
(Assignee) | |
Updated•7 years ago
|
||
Keywords: checkin-needed
|
||
Updated•7 years ago
|
||
Assignee: nobody → wolfgang
|
||
Comment 6•7 years ago
|
||
Please could you add commit message + author info, along the lines of http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed Thanks :-)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
(Assignee) | |
Comment 7•7 years ago
|
||
Created attachment 570251 [details] [diff] [review] better string handling in nsJAR.cpp Same patch as attachment 569337 [details] [diff] [review] with commit headers inside. # HG changeset patch # User Wolfgang Germund <wolfgang@germund.name> # Date 1319809381 -7200 # Node ID bc922174efa4cc6b29693d0fbba3aa652a832980 # Parent 6ec5b28142d10d83046bdce764fbc1fe3598d4be Bug 697061: better string handling in nsJAR.cpp
|
|
||
Updated•7 years ago
|
||
Attachment #569337 -
Attachment is obsolete: true
|
||
Comment 8•7 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/53f92c788b6f
Keywords: checkin-needed
Target Milestone: --- → mozilla10
|
||
Comment 9•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f395b5acb611
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
||
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•