697061 - [followup on bug 296795] better string handling in nsJAR.cpp

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Wolfgang Germund]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111012 Firefox/8.0 SeaMonkey/2.5
Build ID: 20111012194554



Actual results:

The function nsJAR::GetCertificatePrincipal() uses a string transformation, which is not necessary.

see comment https://bugzilla.mozilla.org/show_bug.cgi?id=296795#c39

Comment 1

[Wolfgang Germund]

Attachment: optimized string handling

Work without local copy of aFilename.

Comment 2

[Mozilla RelEng Bot]

Try run for b8ca354cf381 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b8ca354cf381
Results (out of 190 total builds):
    success: 184
    warnings: 6
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-b8ca354cf381

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Did you mean to request review on this? tglek is probably the best choice.

Comment 4

[Wolfgang Germund]

Comment on attachment 569337 [details] [diff] [review]
optimized string handling

Hallo

I have created a followup and tested my new try server account.

The result summary https://tbpl.mozilla.org/?tree=Try&rev=b8ca354cf381 is empty!?
But the comment 2 and the log files on the ftp server looks good.
The firefox build runs fine on Linux.

Comment 5

[(dormant account)]

Comment on attachment 569337 [details] [diff] [review]
optimized string handling

thank you

Comment 6

[Ed Morley [:emorley]]

Please could you add commit message + author info, along the lines of http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

Thanks :-)

Comment 7

[Wolfgang Germund]

Attachment: better string handling in nsJAR.cpp

Same patch as attachment 569337 [details] [diff] [review] with commit headers inside.

# HG changeset patch
# User Wolfgang Germund <[e-mail]>
# Date 1319809381 -7200
# Node ID bc922174efa4cc6b29693d0fbba3aa652a832980
# Parent  6ec5b28142d10d83046bdce764fbc1fe3598d4be
Bug 697061: better string handling in nsJAR.cpp

Comment 8

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/53f92c788b6f

Comment 9

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/f395b5acb611