Last Comment Bug 697061 - [followup on bug 296795] better string handling in nsJAR.cpp
: [followup on bug 296795] better string handling in nsJAR.cpp
Status: RESOLVED FIXED
:
Product: Core Graveyard
Classification: Graveyard
Component: File Handling (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Wolfgang Germund
:
Mentors:
Depends on: 296795
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-25 05:35 PDT by Wolfgang Germund
Modified: 2016-06-22 12:16 PDT (History)
5 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

Attachments
optimized string handling (3.55 KB, patch)
2011-10-25 05:46 PDT, Wolfgang Germund 		taras.mozilla: review+
Details | Diff | Splinter Review
better string handling in nsJAR.cpp (3.78 KB, patch)
2011-10-28 07:03 PDT, Wolfgang Germund 		no flags Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Wolfgang Germund 2011-10-25 05:35:34 PDT 
User Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111012 Firefox/8.0 SeaMonkey/2.5
Build ID: 20111012194554



Actual results:

The function nsJAR::GetCertificatePrincipal() uses a string transformation, which is not necessary.

see comment https://bugzilla.mozilla.org/show_bug.cgi?id=296795#c39
Comment 1 Wolfgang Germund 2011-10-25 05:46:31 PDT 
Created attachment 569337 [details] [diff] [review]
optimized string handling

Work without local copy of aFilename.
Comment 2 Mozilla RelEng Bot 2011-10-25 11:10:27 PDT 
Try run for b8ca354cf381 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b8ca354cf381
Results (out of 190 total builds):
    success: 184
    warnings: 6
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/wolfgang@germund.name-b8ca354cf381
Comment 3 Ryan VanderMeulen [:RyanVM] 2011-10-25 14:05:45 PDT 
Did you mean to request review on this? tglek is probably the best choice.
Comment 4 Wolfgang Germund 2011-10-26 01:49:30 PDT 
Comment on attachment 569337 [details] [diff] [review]
optimized string handling

Hallo

I have created a followup and tested my new try server account.

The result summary https://tbpl.mozilla.org/?tree=Try&rev=b8ca354cf381 is empty!?
But the comment 2 and the log files on the ftp server looks good.
The firefox build runs fine on Linux.
Comment 5 (dormant account) 2011-10-26 08:59:29 PDT 
Comment on attachment 569337 [details] [diff] [review]
optimized string handling

thank you
Comment 6 Ed Morley [:emorley] 2011-10-28 03:18:48 PDT 
Please could you add commit message + author info, along the lines of http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

Thanks :-)
Comment 7 Wolfgang Germund 2011-10-28 07:03:46 PDT 
Created attachment 570251 [details] [diff] [review]
better string handling in nsJAR.cpp

Same patch as attachment 569337 [details] [diff] [review] with commit headers inside.

# HG changeset patch
# User Wolfgang Germund <wolfgang@germund.name>
# Date 1319809381 -7200
# Node ID bc922174efa4cc6b29693d0fbba3aa652a832980
# Parent  6ec5b28142d10d83046bdce764fbc1fe3598d4be
Bug 697061: better string handling in nsJAR.cpp
Comment 8 Boris Zbarsky [:bz] (still a bit busy) 2011-10-28 10:10:18 PDT 
http://hg.mozilla.org/integration/mozilla-inbound/rev/53f92c788b6f
Comment 9 Marco Bonardo [::mak] 2011-10-29 01:47:22 PDT 
https://hg.mozilla.org/mozilla-central/rev/f395b5acb611
Note You need to log in before you can comment on or make changes to this bug.